Re^3: Equation - code review

You have been very polite and my inclination is to help you. Please make it easier to do so.

You have provided us with your current solution to a problem, but you haven't specified what that problem is. It is difficult to identify what areas might be unneccesary or wasteful in this situation.

Some inline documentation would be useful, as would some additional comments in this thread. Here are a few things that would be nice to know:

Why is $distance_index and $window random
More sample data. The $sequence provided is 7 characters, but in this comment you state that it can be over 1000 characters in length. The size of the input data will help determine which algorithm is appropriate.
How often will this function be called

Comment on Re^3: Equation - code review

Replies are listed 'Best First'.
Re^4: Equation - code review by kulls (Hermit) on Aug 16, 2006 at 08:40 UTC
Hi, User can send the different values of distance, window and sequence as well. through CGI interface and this refined subroutine will be used inside the package and all the validation controlled by the CGI itself. . I need to extend my functionality based on this single subroutine , Hence I need to sort it out all the obstacles.My observation is, concerned with Math::Bigint package which created a new object (inside the forloop), I'm using `substr` method to pare the characters. Can you please suggest me, If any where I can improve the performance. - kulls	[reply] [d/l]

Replies are listed 'Best First'.

Re^4: Equation - code review
by kulls (Hermit) on Aug 16, 2006 at 08:40 UTC

substr

[reply]
[d/l]