in reply to Re: Re: Is this safe??
in thread Is this safe??

What do I need to check to make sure I'm not letting anything slip by?

As described above, use both taint mode and CGI.pm as follows: 

#!/usr/bin/perl -wT
#warnings and taint mode now enabled
use CGI;
#you may now use the CGI methods.

[download]
It would scare me greatly if you copied this code from a company web page since those pages are now vunerable to a variety of DoS and hack attacks. CGI has tested-true functions for nearly everything you do above. It looks like you could reduce that program to 10 lines or less OF SECURE CODE!

On CGI security: If you're not using the inputted data in shell calls, then you're relatively safe. Taint mode specifically checks for this. Of course, some loser can still input some random schlop, so work your CGI with "valid entry or reject"/deny-allow in mind. As I said earlier, CGI.pm provides numerous functions for EXACTLY what you are doing (and doing incompletely), including character escaping, so click that link and read the docs on it.

AgentM Systems nor Nasca Enterprises nor Bone::Easy nor Macperl is responsible for the comments made by AgentM. Remember, you can build any logical system with NOR.

Replies are listed 'Best First'.
Too late for "-T"?
by SilverB1rd (Scribe) on Feb 07, 2001 at 03:47 UTC
    I'm working on a new scritp with the CGI stuff and its giving me this error when I run it on my pc that says "Too late for the "-T" option at mailer.cgi line 1." Is this just because on running it on a pc?
[reply]

      It's probably because you're running it as 

      perl foo.pl

      [download]

      When the first line of the script looks something like: 

      #!c:\perl\bin\perl -T

      [download]

      Just change the command line to perl -T foo.pl, or execute the script directly (i.e. don't run it through the interpreter on the command line) and you're golden.

      P.S. "P.C." usually refers to the archictecture (i386), I understand you as meaning "Windows," my apologies if that assumption is incorrect.

      HTH

      Philosophy can be made out of anything. Or less -- Jerry A. Fodor

[reply]
[d/l]
[select]
        Thanks that was the problem. And yes I'm running perl in windows.
[reply]
[reply]
        So far I have this script that just displays all the fields. Now I need to be able to open the template files for the email securly. 
        #!/usr/bin/perl -Tw

#warnings and taint mode now enabled 

use CGI; 
use strict; 

#you may now use the CGI methods. 

print "Content-type:text/html\n\n";

print "<html><body>";
my ($query) = new CGI;
my (@values, $key);

foreach $key ($query->param) {
@values = $query->param($key);
print "$key = @values\n";
}

print "</body></html>";

        [download]
[reply]
[d/l]
Thanks
by SilverB1rd (Scribe) on Feb 07, 2001 at 01:54 UTC
    Thanks I'll do that and let you all know how it works! I wrote that script.
[reply]

In Section Seekers of Perl Wisdom