in reply to Use of a global scalar

Using our within a block makes the variable a package global only within that block. To make the global valid throughout the entire file, simple put our $text at the top. You're also re-declaring $text inside your while loop each time and then matching it, which doesn't make sense, and should result in a "Use of uninitialized value in substitution" warning.

However, it's good practice to avoid global variables when possible. Instead, you can do something like this: 

use strict;
use warnings;
use Data::Dumper;

sub load_file { 
    my $file = shift;
    my $text;
    { 
        local $/;
        open my $fh, $file or die "Can't open $file $!";
        $text = <$fh>;
    }
    return $text;
}

my $text = load_file( '/home/greyfox/data/TBLLOTUSNOTESPYRAMID.txt' );

[download]

Then, you can pass $text as a parameter to a subroutine that processes the second file, for example.

Replies are listed 'Best First'.
Re^2: Use of a global scalar
by betterworld (Curate) on Sep 03, 2006 at 02:22 UTC
    You're also re-declaring $text inside your while loop each time and then matching it, which doesn't make sense, and should result in a "Use of uninitialized value in substitution" warning.
    This is not true. An our-variable is declared only for the current block, but it's the same variable every time you declare it. The following code works fine: 
    use strict;
use warnings;

{
    our $text = 'test';
}
{
    our $text =~ s/t/T/;
}
{
    print our $text; # "Test"
}

    [download]
    However I can't tell why Grey Fox's code doesn't work. He should have provided the input files.
[reply]
[d/l]

In Section Seekers of Perl Wisdom