in reply to Service controller for Linux/Unix

We use scripts like this for some other service-type applications on our system (though not necessarily via /etc/rc.d) a LOT. A lot of applications make the assumption that one or two instances of a given application will be installed, so they give you one 'admin' script for each instance and you issue a set of start/stop/status type commands to run it. Since we have dozens of instances running, this can be painful, so like you, we've set up scripts that reverse the order of the action. Instead of telling instance X to start, we "start" instance X.

I might suggest the following changes: 

my $service = shift;
my ($action) = $0 =~ m![^/]+)$!;   # corrected per reply

$service =~ tr~/~~d;

die "$service: No such service" unless -x "/etc/rc.d/init.d/$service" 
+&& -f _;
exec("/etc/rc.d/init.d/$service", $action) or die "exec: $!";

[download]
By using the multi-argument form of exec (or system for that matter), we don't have to worry about shell metacharacters mucking us up. This is probably reasonably safe to run set-uid or via sudo.

Replies are listed 'Best First'.
Re: Re: Service controller for Linux/Unix
by jjhorner (Hermit) on Feb 09, 2001 at 01:29 UTC

    In 

    my $action = $0 =~ /([^/]+)$/;

    [download]

    You need to escape your forward slash, and in this format, $action is given a true value ('1'), but is not given the result of the match.

    The following works and is added to the code: 

    $0 =~ /([^\/]+)$/;
my $action = $1;

    [download]

    Thanks for your comments. 

    J. J. Horner
Linux, Perl, Apache, Stronghold, Unix
jhorner@knoxlug.org http://www.knoxlug.org/
[reply]
[d/l]
[select]
      You're right; I had intended to write something more like this: 
      my ($action) = $0 =~ m!([^/]+)$!;

      [download]
      Either way, you figured it out. I usually prefer the one-line form like this, because with the two-line form, if the regex fails, an assignment to $1 might get you something you do not expect (the results from a previous regex, for example).
[reply]
[d/l]

In Section Code Catacombs