in reply to OUR declaration

I usually use our in preference to use vars because it allows a declaration and assignment in one go: 

our $globalvar = 10;

[download]

For global variables, I usually use our in preference to my because it doesn't create closures within subs, which can cause problems under mod_perl.


--
sgifford's Web page

Replies are listed 'Best First'.
Re^2: OUR declaration
by nobull (Friar) on Sep 24, 2006 at 13:03 UTC
    When using our as an alternative to my in pseudo-CGI scripts that'll be running under mod_perl I recommend getting into the habit of using local our so that you get a pseudo "global destruction" at the end of the pseudo-CGI script.

    Otherwise, if the declaration doesn't initialise, the value from a previous execution of the script may persist and also if there are any destruction side effects (like closing files) these may get deferred.

[reply]
[d/l]
[select]
      I don't reccommend using our "as an alternative to my" under mod_perl. They don't do the same thing, and mod_perl doesn't change that. If you are using "our" because your code has unintentional closures around "my" variables that showed up when you used mod_perl, you should really change your code to fix this problem. It can bite you in other ways, and "local our" is a pretty nasty construct.
[reply]
        The mod_perl Reference recommends exactly that.

        While there are differences between using my and our for global variables, in my experience they don't come into play in most scripts unless they're run under something which turns all your subroutines into inner subroutine, like mod_perl. That's why I suggested using our for global variables, since it works the same in both scenarios.

        My understanding is the our was a right and proper way to declare package globals.

        Are there problems you're aware of with using our for package globals under mod_perl or anywhere else?


        --
        sgifford's Web page
[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom