in reply to Re: SOAP::Lite and HTTP status line
in thread SOAP::Lite and HTTP status line

IMHO there should be a switch for nph

I tried to modify SOAP/Transport/HTTP.pm. Since I hardly have any experience at patching others' code, I thought it would be a good idea to ask for advice here instead of submitting a possibly wrong bug report/fix. Well, this is the original code of S::T::H::CGI::handle:

sub handle { my $self = shift->new; my $length = $ENV{'CONTENT_LENGTH'} || 0; if (!$length) { $self->response(HTTP::Response->new(411)) # LENGTH REQUIRED } elsif (defined $SOAP::Constants::MAX_CONTENT_SIZE && $length > $SO +AP::Constants::MAX_CONTENT_SIZE) { $self->response(HTTP::Response->new(413)) # REQUEST ENTITY TOO LAR +GE } else { my $content; binmode(STDIN); read(STDIN,$content,$length); $self->request(HTTP::Request->new( $ENV{'REQUEST_METHOD'} || '' => $ENV{'SCRIPT_NAME'}, HTTP::Headers->new(map {(/^HTTP_(.+)/i ? $1 : $_) => $ENV{$_}} k +eys %ENV), $content, )); $self->SUPER::handle; } # imitate nph- cgi for IIS (pointed by Murray Nesbitt) my $status = defined($ENV{'SERVER_SOFTWARE'}) && $ENV{'SERVER_SOFTWA +RE'}=~/IIS/ ? $ENV{SERVER_PROTOCOL} || 'HTTP/1.0' : 'Status:'; my $code = $self->response->code; binmode(STDOUT); print STDOUT "$status $code ", HTTP::Status::status_message($code), "\015\012", $self->response->headers_as_string, "\015\012", $self->response->content; }

And I applied these changes:

# imitate nph- cgi for IIS (pointed by Murray Nesbitt) - my $status = defined($ENV{'SERVER_SOFTWARE'}) && $ENV{'SERVER_SOFTW +ARE'}=~/IIS/ - ? $ENV{SERVER_PROTOCOL} || 'HTTP/1.0' : 'Status:'; + my $status; + if ($self->{'nph'}) { + $status = $ENV{SERVER_PROTOCOL} || 'HTTP/1.0'; + } else { + $status = defined($ENV{'SERVER_SOFTWARE'}) && $ENV{'SERVER_SOFTWA +RE'}=~/IIS/ + ? $ENV{SERVER_PROTOCOL} || 'HTTP/1.0' : 'Status:'; + } my $code = $self->response->code;

Plus, I added a nph function:

sub nph { my $self = shift; $self->{'nph'} = 1; return $self; }

So now, I just add a call to nph and I get a proper HTTP response:

SOAP::Transport::HTTP::CGI ->dispatch_to ('/home/hue/lang/perl/modules', 'HelloWorld') ->nph ->handle;

Do you monks thing it's ok to submit this? Thank you for your valuable input.

--
David Serrano

Replies are listed 'Best First'.
Re^3: SOAP::Lite and HTTP status line
by shmem (Chancellor) on Sep 24, 2006 at 10:57 UTC
    I think that's perfectly ok for submission.

    --shmem

    _($_=" "x(1<<5)."?\n".q·/)Oo.  G°\        /
                                  /\_¯/(q    /
    ----------------------------  \__(m.====·.(_("always off the crowd"))."·
    ");sub _{s./.($e="'Itrs `mnsgdq Gdbj O`qkdq")=~y/"-y/#-z/;$e.e && print}