Re: File::Find and untaint

what am I doing wrong?

According to the documentation for File::Find:

Note that all names passed to the user's wanted() function are still tainted.

So you have to untaint the @twikipaths array before you use it.

The code:

          $line =~ s/([^\011\012\015\040-\176])//g;
[download]

has superfluous parentheses (in fact all of your regular expressions do) and would be more efficient as:

          $line =~ tr/\011\012\015\040-\176//cd;
[download]

Comment on Re: File::Find and untaint Select or Download Code

Replies are listed 'Best First'.
Re^2: File::Find and untaint by Melly (Chaplain) on Oct 09, 2006 at 17:47 UTC
Ah - many thanks! I must admit to being slightly puzzled by the requirement to untaint with File::Find, but waddaiknow? As for the superfluous parentheses - yes, some tidying up is in order. At one point I was printing out various stuff during a debug, but thanks for the heads-up... Tom Melly, tom@tomandlu.co.uk	[reply]
Re^3: File::Find and untaint by jwkrahn (Abbot) on Oct 09, 2006 at 19:19 UTC
You're welcome. `:-)`	[reply] [d/l]