Re^2: Form letters: eval a string to substutite perl variables

Here's what I want to do more clearly. Given a file:

  "Dear $row->{name}; thanks for giving us money."
[download]

I want to slurp it in:

   undef($/);
   $block = <FILE>;
[download]

Then substitue in a loop:

   $sql = "select email,name from database";
   while( $row=getrow($sql) ) {
      print "Working on $row->{name}\n";
      eval{$block);
      send_email($row->{email},$block);
   }
[download]

The idea is to use perl syntax and the perl parser for the substitution, rather than a made up syntax (e.g. %NAME% and s/%NAME%/$name/). Is this crazy?

Comment on Re^2: Form letters: eval a string to substutite perl variables Select or Download Code

Replies are listed 'Best First'.
Re^3: Form letters: eval a string to substutite perl variables by Joost (Canon) on Oct 27, 2006 at 22:50 UTC
Alright, one remark up front: read up on the difference between eval {block} and eval $string. It's crucial. But also consider this: eval $string is for interpreting strings as code, not for variable substitution. Let's say you've got a string `my $string = 'some $stuff I want to $interpolate';` [download] You can now eval $string to interpolate $stuff and $interpolate, but... You need to add quotes: `my $value = eval "'$string'";` [download] update there's a bug here. read ikegami's reply. The problem with this, is that you can't know if there are any quotes in $string, so you need to escape the quotes in $string before eval()ing. Also, it will interpolate anything that looks like a variable. Even if the variable in question shouldn't be interpolated at all. In general, if you want to give your users the maximum amount of control, use eval. In any other case, you're better off using a templating language. You might even use something like Text::Template, which is fast and works more or less like perl. If you want to use something simple that's more strict in its input, use something like GrandFather's post. "What should it profit a man, if he should win a flame war, yet lose his cool?"	[reply] [d/l] [select]
Re^4: Form letters: eval a string to substutite perl variables by ikegami (Patriarch) on Oct 27, 2006 at 23:39 UTC
Single quotes don't interpolate. You mean `my $value = eval "\"$string\"";` [download]	[reply] [d/l]
Re^5: Form letters: eval a string to substutite perl variables by Joost (Canon) on Oct 27, 2006 at 23:50 UTC
Erm.. Oops, you're right. "What should it profit a man, if he should win a flame war, yet lose his cool?"	[reply]
Re^5: Form letters: eval a string to substutite perl variables by Fletch (Bishop) on Oct 28, 2006 at 15:10 UTC
Or `eval qq{"$string"};` for less backwhackititus.	[reply] [d/l]