Re^2: Sessions problems

Thanks for the advice. I have now moved the session creation code to after the validation checking on the params that i am giving to the session. I was already using use strict; and have added use warnings; I have also changed the $query variable to $q so that it has the value $q = new CGI, created earlier as suggested by dorward. So the code reads as

if($ENV{REQUEST_METHOD} eq 'POST')
{
    $q = new CGI;

    $username = $q->param('user_name');
    $pword = $q->pword'pwd');

}
#####
validate username and pword
#####


my $cgi;
        #Create a new session
        $session = new CGI::Session("driver:File", undef, {Directory=>
+'./tmp/sessions'});

        #Allow cgi-session read the cookie at the next reques
        $cookie = $q->cookie( -name => $session->name,
                          -value => $session->id );

        print $q->header( -cookie=>$cookie);

        $name = $cgi->param($username);
        $session->param($username, $name);
[download]

Should the value for $cgi at:

        $name = $cgi->param($username);
[download]

be $q as well or rather my $cgi = new CGI? Currently i have it defined at the beginning of the script as my $cgi; It is not causing an issue as at the moment i am still getting the error "Can't call method "cookie" on an undefined value at" Again i would really appreciate your help and suggestions with this problem thanks

Comment on Re^2: Sessions problems Select or Download Code

Replies are listed 'Best First'.
Re^3: Sessions problems by f00li5h (Chaplain) on Dec 13, 2006 at 11:00 UTC
I presume you only seting `$q` when it's a POST request to make sure that users only login with POST, but i think you'll still want to have a `my $q = CGI->new()` since you may want to, say, set `$q->cookie` or do a `$q->header 'location: http://elsewhere.com/'` etc regardless of wether the user has posted the form... `CGI::param 'foo'` will give you back foo from get/post-age, and will play nice and give you an `undef` if the form wasn't posted or that field wasn't supplied. If you're not unconditionally putting something in `$q` then you can't trust `$q` to be defined and so you should check that there's something there, every time you want to call something on it. It's only safe to do `$q->somestuff()` if `ref $q` ie you can only use methods on $q if it is an object (ie if it's a blessed reference) HTH `@_=qw; ask f00li5h to appear and remain for a moment of pretend better than a lifetime;;s;;@_[map hex,split'',B204316D8C2A4516DE];;y/05/os/&print;`	[reply] [d/l] [select]
Re^4: Sessions problems by Anonymous Monk on Dec 13, 2006 at 11:18 UTC
I actually have one more question with regards to retrieving the value in the cookie from a different cgi file. I am using the sample code form the CPAN tutorial `$name = $session->param($username); printf "<input type=\"text\" name=\$username\" value=\"%s\" />", $name +;` [download] Just wondering should as in the creating the session, $name here be defined as `my $name ->new CGI()` or just `my $name` also the value that i passed into the session was `$name = $query->param($username); $session->param($username, $name);` [download] so in retrieving the cookie am i right to put `$username` into the "param" field in the line `$name = $session->param($username);` and into the name field in the line `printf "<input type=\"text\" name=\$username\" value=\"%s\" />", $name +;` [download] Thanks again	[reply] [d/l] [select]
Re^5: Sessions problems by f00li5h (Chaplain) on Dec 13, 2006 at 20:57 UTC
I'm not sure if you've read it, but Ovid wrote a CGI course that you may be interested in Also, merlyn wrote some neat Web Techniques Columns that may interest you. Oh, and I think there's a book on Perl CGI too... ;) `@_=qw; ask f00li5h to appear and remain for a moment of pretend better than a lifetime;;s;;@_[map hex,split'',B204316D8C2A4516DE];;y/05/os/&print;`	[reply] [d/l]
Re^4: Sessions problems by Anonymous Monk on Dec 13, 2006 at 11:06 UTC
Adding a `my $q = CGI->new()` seemed to do the trick, thanks for all the help, appreciate it!	[reply] [d/l]
Re^3: Sessions problems by themage (Friar) on Dec 13, 2006 at 10:52 UTC
Yes, all the uses of `$cgi` should be tranformed to `$q`. TheMage Talking Web	[reply] [d/l] [select]