in reply to Re: Five Ways to Reverse a String of Words (C#, Perl 5, Perl6, Ruby, Haskell)
in thread Five Ways to Reverse a String of Words (C#, Perl 5, Perl 6, Ruby, Haskell)

Nice, but you're counting on the special variable $" to have its default value. There's no reason for people not to touch it.

Either use join, or use 

local $" = ' ';

[download]
in your sub.
  • Comment on Re^2: Five Ways to Reverse a String of Words (C#, Perl 5, Perl6, Ruby, Haskell)
  • Download Code

Replies are listed 'Best First'.
Re^3: Five Ways to Reverse a String of Words (C#, Perl 5, Perl6, Ruby, Haskell)
by shmem (Chancellor) on Dec 13, 2006 at 11:37 UTC
    ...yeah, and if I get paranoid I also check whether the stringify and/or (de)ref operators are overloaded, and maybe somebody changed shift and reverse via e.g. schwern's Function::Override... ;-)

    I guess that if somebody changes $" globally, they have a reason, now don't they?

    --shmem

    update: inserted globally 

    _($_=" "x(1<<5)."?\n".q·/)Oo.  G°\        /
                              /\_¯/(q    /
----------------------------  \__(m.====·.(_("always off the crowd"))."·
");sub _{s./.($e="'Itrs `mnsgdq Gdbj O`qkdq")=~y/"-y/#-z/;$e.e && print}
[reply]
      Humbug. If your function API isn't explicitely saying it's using the current value of $", then it shouldn't use its current value.

      Do not assume people haven't touched it. They have every right to, without having to appologize for it, to you.

[reply]
        Keep cool. I didn't publish any function API, but I might do so.

        Anyways, you're right in "counting on the default value", and in production use $" should be localized. I just didn't find it being necessary in the context of this thread.

        --shmem 

        _($_=" "x(1<<5)."?\n".q·/)Oo.  G°\        /
                              /\_¯/(q    /
----------------------------  \__(m.====·.(_("always off the crowd"))."·
");sub _{s./.($e="'Itrs `mnsgdq Gdbj O`qkdq")=~y/"-y/#-z/;$e.e && print}
[reply]
      Don't forget code filters, too! :-) Just because it says "sub" doesn't mean it actually *means* sub! ;-)
[reply]

In Section Meditations