Re: Validate newline delimited email list

Works for me except I had to initialize $email_list, initialize $error_message and print $error_message. Could you provide a snippet that actually shows the error?

There are a couple of details worth mentioning.

split( /\n/, ... )
[download]

is easier to read than

split( /
/, ... )
[download]

... if( $error > 0 );
[download]

or just

... if $error;
[download]

is easier to read than

... unless( $error < 1 );
[download]

Comment on Re: Validate newline delimited email list Select or Download Code

Replies are listed 'Best First'.
Re^2: Validate newline delimited email list by philosophia (Sexton) on Jan 12, 2007 at 21:35 UTC
the current version of this code looks like `my ($error) = 0; my (@other_addresses) = split( /\n/, $email_list ); foreach (@other_addresses) { my $ok = Email::Valid->address($_); $error++ if(!$ok); print "address($_) = $ok\n"; print "error ".$error."<br>"; } $error_message .= "$error Email list contains an invalid email ad +dress.<br>" if $error;` [download] and gives me `address(test@test.com ) = error 1 address(test2@test.com) = test2@test.com error 1 There was an error with your form submission. 1 Email list contains an invalid email address.` [download] it seems to let every address through whether it is valid or not.	[reply] [d/l] [select]
Re^3: Validate newline delimited email list by ikegami (Patriarch) on Jan 12, 2007 at 21:50 UTC
`"test@test.com "` is indeed bad. Notice the trailing space? It's easy to fix the address, though. `sub trim { my ($s) = @_; for ($s) { s/^\s+//; s/\s+$//; return $_; } } ... my @other_addresses = map trim, split( /\n/, $email_list ); ...` [download]	[reply] [d/l] [select]
Re^4: Validate newline delimited email list by philosophia (Sexton) on Jan 12, 2007 at 22:20 UTC
i put the above in my code and sub trim; at the top of my script. I get `address() = error 1 address() = error 2 There was an error with your form submission.` [download]	[reply] [d/l]
Re^4: Validate newline delimited email list by philosophia (Sexton) on Jan 12, 2007 at 22:44 UTC
shouldn't chomp() remove the trailing space? i've tried chomp($_) and it looks like the space is still there. i've tried your suggestion above, and it doesn't seem to populate $_	[reply]
Re^5: Validate newline delimited email list by ikegami (Patriarch) on Jan 12, 2007 at 22:52 UTC
Re^4: Validate newline delimited email list by philosophia (Sexton) on Jan 12, 2007 at 22:08 UTC
this gave me a software error, not sure how to deal with it: Bareword "trim" not allowed while "strict subs" in use at...	[reply]
Re^5: Validate newline delimited email list by ikegami (Patriarch) on Jan 12, 2007 at 22:31 UTC
Re^6: Validate newline delimited email list by philosophia (Sexton) on Jan 12, 2007 at 22:33 UTC
Some notes below your chosen depth have not been shown here
Re^3: Validate newline delimited email list by Sagacity (Monk) on Jan 12, 2007 at 22:53 UTC
Looks to me that this line $error++ if(!$ok); is merely testing whether $ok exists, which it always does according to the line above it. `my $ok = Email::Valid->address($_);` [download] Try testing for the value of $ok that was returned instead. `if ($ok == 1) {#the rest of your code } else {# code here too if you like }` [download]	[reply] [d/l] [select]