Re^2: Defactor this code

Awesome, i feel learned lot fro this defector, i have one problem the sshd_config sometime looks like this

#Port 22
Port 4444

#Protocol 2,1
#ListenAddress 0.0.0.0
#ListenAddress ::

After we modify the file with above code it becomes like this

Port 4444
Port 4444

it should be lie

Port 4444

Thanks again

Comment on Re^2: Defactor this code

Replies are listed 'Best First'.
Re^3: Defactor this code by graff (Chancellor) on Feb 11, 2007 at 06:27 UTC
i have one problem the sshd_config sometime looks like this `#Port 22 Port 4444` [download] After we modify the file with above code it becomes like this `Port 4444 Port 4444` [download] Right, that's what your code in the OP does, and that's what I mentioned in my third "bullet" paragraph as probably being a bug. Now, you seem to be saying that you simply want to delete all commented lines (the ones beginning with "#"), which is easy enough to do: `while (<SSHD_CONFIG>) { next if ( /^#/ ); s/^port.+/Port $sshport/i; print SSHD_CONFIG_NEW; }` [download] But some people prefer to leave the comment lines in, because sometimes these lines hold important information that might be useful someday (e.g. documentation, or details about a prior or alternative configuration that might be needed when conditions change). That's why the version in my first reply used the parens and the "$1" in the s/// statement, to preserve the "#" character while changing the port number. Actually, I think it may be best to retain the comment lines unchanged, and only edit the "uncommented" line -- this also turns out to be the simplest method: `while (<SSHD_CONFIG>) { s/^port.+/Port $sshport/i; print SSHD_CONFIG_NEW; }` [download]	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: Defactor this code
by graff (Chancellor) on Feb 11, 2007 at 06:27 UTC

i have one problem the sshd_config sometime looks like this
#Port 22
Port 4444
[download]
After we modify the file with above code it becomes like this
Port 4444
Port 4444
[download]

Right, that's what your code in the OP does, and that's what I mentioned in my third "bullet" paragraph as probably being a bug.

Now, you seem to be saying that you simply want to delete all commented lines (the ones beginning with "#"), which is easy enough to do:

while (<SSHD_CONFIG>) {
    next if ( /^#/ );
    s/^port.+/Port $sshport/i;
    print SSHD_CONFIG_NEW;
}
[download]

That's why the version in my first reply used the parens and the "$1" in the s/// statement, to preserve the "#" character while changing the port number. Actually, I think it may be best to retain the comment lines unchanged, and only edit the "uncommented" line -- this also turns out to be the simplest method:

while (<SSHD_CONFIG>) {
    s/^port.+/Port $sshport/i;
    print SSHD_CONFIG_NEW;
}
[download]

[reply]
[d/l]
[select]