in reply to Re: Inversion list prototype
in thread Inversion list prototype

There are a lot of different cases to consider, with edge cases where the ends of the unions are equal, overlap in different ways, are subsets, proper subsets etc.

Yes indeed. I think i covered most of them in the embedded tests in the script, but perhaps not.

can you steal the unit tests from Algorithm::InversionList?

There actually arent that many, and they arent really relevent, since it seems his version does bitmap compression, whereas mine is working with codepoints. (Not that they arent at certain levels equivelent, but....) Also he hasnt implemented any set operations, just compression/lookup.

Ill check out the exmap. And yeah, ive done code /very/ similar to this for $work, but wasnt looking at it as a set relation, rather as date ranges.

---
$world=~s/war/peace/g

Replies are listed 'Best First'.
Re^3: Inversion list prototype
by jbert (Priest) on Feb 16, 2007 at 18:08 UTC
    I think there are more cases for union.

    The two ranges can be disjoint, they can have upper of one == lower of the other, partially overlap, partially overlap with an end-point in common, be equal, be a strict subset and unless you canonicalise the order somehow you also have all of these the other way round (so double the number of cases, plus some I missed probably).

    I can think of at least ten cases anyway.

    (Edit: after re-reading the tests, I think most cases are covered, so sorry for originally saying "a lot more cases", that was my error in reading the tests)

      You motivated me to add some more tests just now. I havent named them, but I think i have most covered.

      A second set of eyes is always appreciated in these things, as I think you know. :-)

      ---
      $world=~s/war/peace/g