Re^5: Quick feedback option for downvotes (keywords)

They aren't disable for non-special users. But they aren't particularly useful either.

Right. To be precise, I should have said, "You can add keywords, but since the one other essential feature — keyword searching — is disabled (for non-special users), they're completely useless."* My mistake.

Nolo contendere on the appropriateness of the word "security"; what I was referring to was what you described.

Anyway, it may be that we're a long way off from having a usable keyword system. I still maintain that we need one, whether we get it or not. :-)

(*In fact, it's possible to build keyword-based capabilities off-site, since the xml rendering of a node includes the node's keywords.)

A word spoken in Mind will reach its own level, in the objective world, by its own weight

Comment on Re^5: Quick feedback option for downvotes (keywords)

Replies are listed 'Best First'.
Re^6: Quick feedback option for downvotes (keywords) by tye (Sage) on Mar 21, 2007 at 17:50 UTC
keyword searching — is disabled (for non-special users) I was going to say that that is a very inaccurate and misleading way of putting it, since I wasn't aware of the feature existing. But you prompted me to search for the feature. Looking at keyword search, I don't see a problem with allowing all to use it (since it doesn't appear to be a resource hog -- though that will likely change before there is a useful volume of keywords; so I hope the node gets much smarter before then), except that it doesn't appear to use placeholders correctly because keywords with single quotes cause a server error (which means that someone could attempt an SQL injection attack, which I doubt could do anything but I'll not enable it until that is patched). Then we'd have a "keyword search feature" at PerlMonks. I suppose that would be one less barrier to having a "useful keyword search feature" at PerlMonks. And then keywords would no longer be "completely useless" (in your accessment -- I say that they are already useful, if you want to anonymously insult someone by tagging their nodes)... they would be "nearly completely useless" (based on spending some time trying to use keyword search). But thanks for indirectly but eventually bringing that to my attention. Progress, though tiny, might eventually lead somewhere. (: Update: Anyone fixing the lack of placeholder use should just remove the query that doesn't use placeholders. It is silly (and inefficient) to do one query to get a list of node IDs and then use that to do another query that selects on both the list of node IDs and on the keyword again. That will simplify the code and even simplify the complex query. Checking the query plan ("describe") would be good at that point, though, as you don't want to "outsmart" the MySQL optimizer. - tye	[reply]

Replies are listed 'Best First'.

Re^6: Quick feedback option for downvotes (keywords)
by tye (Sage) on Mar 21, 2007 at 17:50 UTC

keyword searching — is disabled (for non-special users)

I was going to say that that is a very inaccurate and misleading way of putting it, since I wasn't aware of the feature existing. But you prompted me to search for the feature. Looking at keyword search, I don't see a problem with allowing all to use it (since it doesn't appear to be a resource hog -- though that will likely change before there is a useful volume of keywords; so I hope the node gets much smarter before then), except that it doesn't appear to use placeholders correctly because keywords with single quotes cause a server error (which means that someone could attempt an SQL injection attack, which I doubt could do anything but I'll not enable it until that is patched). Then we'd have a "keyword search feature" at PerlMonks.

I suppose that would be one less barrier to having a "useful keyword search feature" at PerlMonks. And then keywords would no longer be "completely useless" (in your accessment -- I say that they are already useful, if you want to anonymously insult someone by tagging their nodes)... they would be "nearly completely useless" (based on spending some time trying to use keyword search).

But thanks for indirectly but eventually bringing that to my attention. Progress, though tiny, might eventually lead somewhere. (:

Update: Anyone fixing the lack of placeholder use should just remove the query that doesn't use placeholders. It is silly (and inefficient) to do one query to get a list of node IDs and then use that to do another query that selects on both the list of node IDs and on the keyword again. That will simplify the code and even simplify the complex query. Checking the query plan ("describe") would be good at that point, though, as you don't want to "outsmart" the MySQL optimizer.

- tye

[reply]