in reply to Adding Arrays..

Noob style and code suggestions posted here, with your code, formatted:
#! /usr/bin/perl # # # use strict; # --- Good job on using strict and warnings !! use warnings; #------------------data------------------------- my @Rainfall ; my $Index ; # --- Perl programmers try to avoid using Indexes wh +ere not necessary. # --- IN This case, Index is NOT necessary my ($Total, $Average) = 0, 0; # Wrong intent (result would be OK) - er +ror pointed out by others #------------------program---------------------- print " Enter 12 numbers for the rainfall for each month \n"; for ( $Index = 0; $Index < 12 ; $Index++ ) # --- Perl programmers wou +ld not use "C" style loop { print "Enter a month's rainfall: " ; chomp($Rainfall[$Index]= <STDIN>); # --- } # --- Perl programmer would have done this like: # --- while (<STDIN>){ # --- chomp; # --- push @Rainfall, $_; # --- } # # now we have all the input, we can do things with it: # foreach (@Rainfall) { $Total = $_; # --- Perl programmer would have done: # --- foreach (@Rainfall) { # --- $Total += $_; # --- } # --- print "Total=$Total; Average = " , $Total/scalar(@Rainfall) , + "\n"; # Should have formatting for Avg...

     "Choose a job you like and you will never have to work a day of your life" - Confucius

Replies are listed 'Best First'.
Re^2: Adding Arrays..
by f00li5h (Chaplain) on Mar 29, 2007 at 06:18 UTC

    $Total += $_ for @Rainfall;

    Some perl programmers do things in different ways. Personally, I think postfix'ed flow controll is one of the sweetest bits of syntatic sugar perl provides.

    drink( $vodca + $orange ) while standing;

    @_=qw; ask f00li5h to appear and remain for a moment of pretend better than a lifetime;;s;;@_[map hex,split'',B204316D8C2A4516DE];;y/05/os/&print;
Re^2: Adding Arrays..
by chrism01 (Friar) on Mar 29, 2007 at 23:58 UTC
    Actually, I would use a counted loop because I don't trust users. Also, they don't have to do the counting themselves ....

    Cheers
    Chris