in reply to "Attempt to free unreferenced scalar" and "Scalars leaked: 1" ?

You should be careful about naming modules B - there's a core module named B and depending on how you set up your include path, that one might be loaded instead of your own.

Also, your code is way too small to make any observations about what's going wrong. It looks like a bug in perl - normal code should never free unreferenced scalars or leak - but if your code tries hard enough you might run into problems :-)

  • Comment on Re: "Attempt to free unreferenced scalar" and "Scalars leaked: 1" ?

Replies are listed 'Best First'.
Re^2: "Attempt to free unreferenced scalar" and "Scalars leaked: 1" ?
by licht (Novice) on Mar 31, 2007 at 23:38 UTC

    Names "A" and "B" are used for simplicity. I didn't use them in real codes.

    The following gives short enough but clear code samples that result in 1 warning and 1 error messages that confused me.


    1. "Attempt to free unreferenced scalar" warning.
    for simplicity, there are 2 perl script files: test.pl and test.pm.
    _test.pl_
    use threads; use test; my $argument=1; my $thread=threads->create("forthread", ($argument)); $thread->join(); exit(0);

    _test.pm_
    package test; require Exporter; our @ISA =qw(Exporter); our @EXPORT =qw(queuereader); our @VERSION =1.0; sub forthread{ my ($arg)=@_; return 0; } #forthread

    NOTE: there is no problem if "forthread" is in test.pl. But when we put "forthread" in a separate file other than the caller file, it reports the above warning message, in fact, no matter if we pass any argument at time of thread creation.


    2. "Scalar leaked:1" error.
    It is for simplicity that bareword "argument" is used in place of any type of variable.
    _test.pl_
    use threads; use test; my $thread=threads->create("forthread", (argument)); $thread->join(); exit(0);

    -test.pm_
    package test; require Exporter; our @ISA =qw(Exporter); our @EXPORT =qw(queuereader); our @VERSION =1.0; sub forthread{ my (argument)=@_; my $thread=threads->create("another", (argument)); $thread->join(); return 0; } #forthread sub another{ return 0; } #another

    NOTE: the error is reported when "argument" is one of the following:
    - reference to scalar
    - reference to array
    - reference to hash
    - hash

      There are so many problems with your test code that you are almost certainly not testing the code you think you are. See the comments below:

      package test; require Exporter; our @ISA =qw(Exporter); our @EXPORT =qw(queuereader); ## You are exporting "queuereader" our @VERSION =1.0; sub forthread{ ## Not the forthread function that is in the f +ile! my ($arg)=@_; return 0; } #forthread ## You have no module termination value, 1;

      All of which leads me to believe that you aren't actually running this module when you run test.pl. Instead you are probably picking up another module called test from somewhere else.

      Now to test.pl

      use threads; use test; my $argument=1; ## VVVVVVVVVV---- this is not a function refe +rence, its a string! my $thread=threads->create("forthread", ($argument)); $thread->join(); exit(0);

      If I attempt to run this pair of files:

      ## test.pl use threads; use Testit; my $argument=1; my $thread=threads->create( 'forthread', ($argument)); $thread->join(); exit(0); ## Testit.pm package Testit; require Exporter; our @ISA =qw(Exporter); our @EXPORT =qw(forthread); our @VERSION =1.0; sub forthread{ my ($arg)=@_; warn "$arg"; return 0; } 1;

      I get the following output:

      C:\test>test.pl 1 at Testit.pm line 11. Attempt to free unreferenced scalar: SV 0x194aa50, Perl interpreter: 0 +x18290c4 during global destruction.

      Which shows that the function forthread has been exported from the package Testit into main, and has been run as a thread, but when the cleanup of the thread happens, it detects a leaked scalar--the string you passed.

      However, if I modify test.pl to pass a coderef rather than a string to the thread creation

      use threads; use Testit; my $argument=1; my $thread=threads->create( \&forthread, ($argument)); $thread->join(); exit(0); __END__ C:\test>test.pl 1 at Testit.pm line 11.

      I get no error. There are two ways of looking at this. The ability to pass a subroutine name as a string (and possibly a bareword if not using strict?) is a throwback to earlier time (perl 4?), but the code underlying the autoresolution of a string to a coderef is still embedded in the API code. However, newer modules and features may have been written by authors who never used this feature, and so their code does not cater for it.

      Specifically, the string containing the function name is duplicated as a string for use on the thread that will be created, but because the author(s) of the threads module where expecting a coderef, they do not deal with this situation. So the other way of looking at it is that this is a bug in the threads module somewhere.

      The simplest way of avoiding it is to pass a coderef in the first place.

      And when you post demo code, it would be nice if it actually worked to demonstrate the problem described :) test.pm is a bad choice of module/package name.


      Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
      "Science is about questioning the status quo. Questioning authority".
      In the absence of evidence, opinion is indistinguishable from prejudice.

        Thanks a lot! BrowserUk. You are really great!

        I'm sorry in fact there are some typos such as exported function names and missing the "1;" at the end of test.pm, etc. I should've double check my post...

        But I am really weak on this part. The syntax to specify the subroutine-name in threads->create is confusing to me. And I guess maybe the latest release has addressed this problem (passing subroutine-name as string instead of code-ref). I have another question about code ref. In fact, I want my code to deal with unknown subroutine name beforehand. Instead, the name may be given in a parameter file in XML like the following:

        <thread> <module>module_name</module> <subroutine>subroutine_name</subroutine> </thread>

        A script reads the file and put modulename in var "$module" and subroutinename in "$subroutine". Then, what is the correct syntax to create a thread for "$subroutine"? I guess I have to use Module::Load to dynamically load a module first and then call threads->create to run a thread for a subroutine. Will this cause some problem?


        Thanks!

        And I rewrite 2nd part as follows. Please help. Thanks!


        "Scalar leaked:1" error.
        It is for simplicity that bareword "argument" is used in place of any type of variable.
        _test.pl_
        use threads; use test; my $thread=threads->create('forthread', (argument)); $thread->join(); exit(0);

        -test.pm_
        package test; require Exporter; our @ISA =qw(Exporter); our @EXPORT =qw(forthread); our @VERSION =1.0; sub forthread{ my (argument)=@_; my $thread=threads->create('another', (argument)); $thread->join(); return 0; } #forthread sub another{ return 0; } #another

        NOTE: the error is reported when "argument" is one of the following:
        - reference to scalar
        - reference to array
        - reference to hash
        - hash