I say read again, harder this time. ! ( defined $ENV{EDITOR} && defined $ENV{VISUAL} ) will be false iff both are defined; the suggested solution will only be true iff both are not defined (i.e. neither the one nor the other are defined, which is just what it said to begin with).