Re^2: How Much Is Too Much (on one line of code)?

One does, other doesn't. Just like I do not see any reason to rewrap "Stay at home if it rains." to "If it rains, stay at home." I do not see the need to rewrap statement modifiers.

Jenda
Support Denmark!
Defend the free world!

Comment on Re^2: How Much Is Too Much (on one line of code)?

Replies are listed 'Best First'.
Re^3: How Much Is Too Much (on one line of code)? by duelafn (Parson) on Jun 18, 2007 at 15:41 UTC
The issue is the other conditional. `If the dog is barking let him in otherwise give him a bone, but only if it is raining.` This sentence reads nicer if we place the "if it is raining" earlier in the sentence. I however, would force the truth of `$country` `my $country = $card->country \|\| 'gbr'; $country = $country eq 'gbr' ? '' : uc "[$country]";` [download] Unfortunately, this breaks when we need to check definedness (until we have a reliable `//` operator). In that case (assume "0" is a valid country) I would probably go with something like: `my $country = $card->country; $country = (!defined($country) or $country eq 'gbr') ? '' : uc "[$coun +try]";` [download] Which is just as complex as the original, but the full conditional is easier to find. Good Day, Dean	[reply] [d/l] [select]
Re^4: How Much Is Too Much (on one line of code)? by robot_tourist (Hermit) on Jun 20, 2007 at 07:17 UTC
I would add a comma after 'let him in', it splits the clauses better. How can you feel when you're made of steel? I am made of steel. I am the Robot Tourist. Robot Tourist, by Ten Benson	[reply]