in reply to How Much Is Too Much (on one line of code)?

IMHO there's not too much on that single second line, but it's written in a needlessly confusing way. The postfix if can be avoided with a conditional assignment: 
    my $country = $card->country;
    $country  &&= $country eq 'gbr' ? '' : uc "[$country]";

[download]

Much clearer. But I agree with halley in that the two cases of the business logic should be handled in separate statements.

--shmem 

_($_=" "x(1<<5)."?\n".q·/)Oo.  G°\        /
                              /\_¯/(q    /
----------------------------  \__(m.====·.(_("always off the crowd"))."·
");sub _{s./.($e="'Itrs `mnsgdq Gdbj O`qkdq")=~y/"-y/#-z/;$e.e && print}

In Section Seekers of Perl Wisdom