Re: How Much Is Too Much (on one line of code)?

I think it's too much.

my $country = $card->country;
$country = '' if $country eq 'gbr';
$country = uc("[$country]") if $country;
[download]

That, or:

my $country = $card->country;
if ($country and $country ne 'gbr') {
    $country = uc("[$country]");
} else {
    $country = '';
}
[download]

Comment on Re: How Much Is Too Much (on one line of code)? Select or Download Code

Replies are listed 'Best First'.
Re^2: How Much Is Too Much (on one line of code)? by kwaping (Priest) on Jun 18, 2007 at 17:15 UTC
Cast my vote for "too much on one line". The solution I wrote was exactly the same as the first solution above, by ForgotPasswordAgain (lol). I'm honestly surprised that it took this far down the thread for someone to post those simple lines of code. Are we all getting too fancy for our own good...? --- It's all fine and dandy until someone has to look at the code.	[reply]