Bonjour:

I think I understand your motivations, maybe it's because you have a 'lingering' session issue - you serve up a sessionid in a cookie and the user goes away forever (i.e. clears their cookies.) That session never expires because they never come back. Before you know it your session table is poopy big. :-)

Advice? Take that whole block out of 'eval {}' and watch for errors. Also, why load the session at all why not just fire off a 'DELETE FROM Session where id=$id' on te $sth?

Good Luck!
KPH

perleager:

I was reading the CGI::Session manual (like a good little developer does :-)) and I noticed that you are using the DEPRECATED method 'close()' (the horror!!)

Currently you call 'load()' (passing in the ID) and then call 'is_expired()', and then, if it's expired, call delete(). My thought is that CGI::Session, when it calls the 'load()' it may very well call the 'is_expired()' off the hop. Are you 100% sure that after load()ing an 'expired session' that CGI::Session isn't doing data store cleanup? (ie. already removing it)

IMO - I think you should write your own 'is_expired()' sub that inspects a Session.ID using DBI, which returns true/false. Write another sub that takes a Session.ID and deletes it's using DBI (e.g execute SP or DELETE statement.) Once you've got those pieces done, your CRON job loops front to back on the Session table, passing each ID to the 'is_expired()' sub, calling the delete when true. Conceptually what you have already but avoid the load()ing of the already expired session.

Maybe I'll just have to write some code to show you what I mean.... if you're even still reading this thread. ;-)

Kurt

Huh? I'd say the example was above average for legibility - you should see some of the legacy Perl code I have had to maintain over the years. It's true that one of the lines is two characters too far (oh calamity!) and that the tabbing isn;t in perfect multiples (oh the shame of it ;)). But at least reasonable effort appears to have been made in regard to appearance albeit not up perltidy's exacting standards. I wouldn't say it goes anywhere near far astray enough to deserve your implied threat, however.
__________________________________________________________________________________

^M Free your mind!

I guess I was too curt, that wasn't an implied threat, it was advice on making things easier on cow orkers or others. It was based on this: I tried to figure out if the disconnect was in the right place in the loop and I had to manually count the braces to do that. Better indenting would have made it obvious at a glance.

use DBI;
    my $dbh = DBI->connect($main::location, $main::user, $main::ba_pas
+s, { RaiseError => 1, AutoCommit => 1}) or die "Couldn't connect to d
+atabase: " . $DBI::errstr;

eval {

        my $sth= $dbh->prepare("SELECT id FROM sessions");

        my $id;
        $sth->execute();
        $sth->bind_columns(undef, \$id);

          require CGI::Session; 
          import CGI::Session;

    while ($sth->fetch()) {
               
      my $session = CGI::Session->load("driver:MySQL", $id, {Handle=>$
+dbh});
         next if $session->is_empty;   
                     
            if (($session->ctime + $session->etime) <= time()) {
              
                  $session->delete();
            
            }

    }
    
};
if ($@) {
    print $@;
    $dbh->disconnect();
}
[download]

Hi perleager. I didn't mean to sound too harsh, and it's not like indenting is the most important thing and tastes vary. But in a chunk of code like you have, I find it most useful to indent mostly based on blocks -- start the indent with the opening "{" of the block and end the indent with the closing "}". This lets you see at a glance which block each line is part of and also to easily check to make sure you didn't omit a curly brace. I sometimes also indent arguments to functions using the opening and closing parentheses to see where to indent. Here's how I would indent your code (again, tastes vary, this is just my way):

use DBI;

my $dbh = DBI->connect(
    $main::location,
    $main::user,
    $main::ba_pass,
    {RaiseError=>1,AutoCommit=>1}
) or die "Couldn't connect to database: " . $DBI::errstr;

#
# indent one level for the eval block
#
eval {
    my $sth= $dbh->prepare("SELECT id FROM sessions");
    my $id;
    $sth->execute();
    $sth->bind_columns(undef, \$id);
    require CGI::Session;
    import CGI::Session;
    #
    #  indent a second level for the while block
    #
    while ($sth->fetch()) {
        my $session = CGI::Session->load(
            "driver:MySQL", $id, {Handle=>$dbh}
        );
        next if $session->is_empty;
        #
        # indent a third level for the if block
        #
        if (($session->ctime + $session->etime) <= time()) {
            $session->delete();
        }
    }
};
if ($@) {
    print $@;
    $dbh->disconnect();
}
[download]

update:renamed it so I could find it :-)

The best answer is in the previous post than mine, I'd only explain it: You need to call this piece of code $query->finish (); atripathi at ea dot com

$query->finish (); is the answer, thx guys.