Re: Make sense?

The only thing I would worry about is that there is no guarantee that keys or values called on %hash more than once will return them in the same order. And keys %hash and values %hash might not return them in the same order

At least that is what I understood. If I am wrong, please tell me. Or is this something that "works" but isn't "right"?

I would probably (untested)

sub _init {
    my ($self, %initdata) = @_;
    if (%initdata) {
        map { $self{$_} = $initdata{$_} } keys %initdata;
    }
}
[download]

l8rZ,

--
andrew

Comment on Re: Make sense? Download Code

Replies are listed 'Best First'.
Re^2: Make sense? by ikegami (Patriarch) on Jul 19, 2007 at 20:13 UTC
From the docs for `keys`: The keys are returned in an apparently random order. The actual random order is subject to change in future versions of perl, but it is guaranteed to be the same order as either the values or each function produces (given that the hash has not been modified). For a given hash, as long as it's not changed, `keys`, `values` and `each` will return keys and/or values in the same order.	[reply] [d/l] [select]
Re^2: Make sense? by NetWallah (Canon) on Jul 20, 2007 at 05:04 UTC
afresh1 .. You probably meant that to be `map { $self->{$_} = $initdata{$_} } keys %initdata;` [download] since there is no indication of the existance of a %self hash, or the relevance of such a hash to the object. Also, there is not need for the "if" since empty "keys" will effectively convert the map to a no-op. So your code is equivalent to the hash slice jdporter wrote. My preference would be to simplify it to : `%$self = (%$self, %initdata);` [download] which, although representing infinitasmally more overhead, has an elegant simplicity to it. If you really wanted to be non-destructive of $self or $_[0], you could: `$self->{$_}=$initdata{$_} for keys %initdata;` [download] which, to me, is slightly more readable/DWIM, compared to a "map" whose result is thrown away. "An undefined problem has an infinite number of solutions." - Robert A. Humphrey "If you're not part of the solution, you're part of the precipitate." - Henry J. Tillman	[reply] [d/l] [select]