Re: how to speed up dupe checking of arrays

Most likely you're going to simply be throttled by IO speed. However, your above code could in theory be simplified by limiting the split to only 3 parts, and by adding the dup check to the while loop. Assuming that dup count is all you really care about.

if ($file =~ $spec_text){
    my $file_date = (split(/\./,$file))[3];
    open(IN, '<', $file) or die("open failed: $!");
    my $count_uniq = 0;
    my %seen;
    while (<IN>) {
        chomp;
        my ($ele0, $ele1, undef) = split ';', $_, 3;
        $count_uniq++ if !$seen{"$ele0;$ele1;$file_date"}++;
    }
    print "$.\n"; # Total number of lines.
    print "$count_uniq\n";
    close(IN);
}
[download]

- Miller

Comment on Re: how to speed up dupe checking of arrays Download Code

Replies are listed 'Best First'.
Re^2: how to speed up dupe checking of arrays by ultibuzz (Monk) on Jul 31, 2007 at 10:25 UTC
i need them in an array so i adjusted ur code like this `my @rows; my %seen; while (<IN>) { chomp; my ($ele0, $ele1, undef) = split ';', $_, 3; push @rows,"$ele0;$ele1;$file_date" if !$seen{"$ele0;$ele1 +;$file_date"}++; } close(IN);` [download] and waht shoud i say AWSOME, from 203 seconds down do around 11 seconds,great so no over hours in office needed ;) thx alot. kd ultibuzz	[reply] [d/l]
Re^3: how to speed up dupe checking of arrays by oha (Friar) on Jul 31, 2007 at 10:46 UTC
you already have them in array. `$seen{"$ele0;$ele1;$file_data"}++;` [download] then if you need the data you can, for example: `foreach (keys %seen) { .... }` [download] and the value of the hash is the number of times the string is repeated Oha	[reply] [d/l] [select]