$sql = "declare \@usrid int, \@sysusrid int " .
       "select \@sysusrid = suser_id\(\'$usrname\'\) " .
       "select \@usrid = $IDVALUE from $ID " .
       "where $IDNAME = \'USR_ID\' " .
       "insert into APPUSR (APP_CD, USR_ID, USRNAME, USRFNAME, USRLNAM
+E, FNCGRP_CD, SYSUSR_ID) " .
       "values (\'A\', \@usrid, \'$usrname\', \'$first\', \'$full_last
+\', $fncgrp, \@sysusrid)";
[download]

Please don't! This code is hard to read and dangerous!

First, this is Perl, not Visual Basic or some other language with restricted string literals. You can write this much more readably. And actually even if you kept using doublequotes you do not need to escape singlequotes. "d\'Artagnan" is equivalent to "d'Artagnan". You could write the code like this:

$sql = qq{
  declare \@usrid int, \@sysusrid int
  select \@sysusrid = suser_id('$usrname')
  select \@usrid = $IDVALUE from $ID
  where $IDNAME = 'USR_ID'

  insert into APPUSR (APP_CD, USR_ID, USRNAME, USRFNAME, USRLNAME, FNC
+GRP_CD, SYSUSR_ID)
  values ('A', \@usrid, '$usrname', '$first', '$full_last', $fncgrp, \
+@sysusrid)
};
[download]

In either case it's dangerous! Guess what happens if someone claims his username is "d'Artagnan"? Or maybe "') delete from APPUSR; select length('gotcha" ?

USE placeholders!

my $sth = $$dbhCurrent->prepare( qq{
  declare \@usrid int, \@sysusrid int
  select \@sysusrid = suser_id(?)
  select \@usrid = $IDVALUE from $ID
  where $IDNAME = 'USR_ID'

  insert into APPUSR (APP_CD, USR_ID, USRNAME, USRFNAME, USRLNAME, FNC
+GRP_CD, SYSUSR_ID) " .
  values ('A', \@usrid, ?, ?, ?, ?, \@sysusrid)
};
$sth->execute( $usrname, $usrname, $first, $full_last, $fncgrp);
[download]

Something to note - Chris is using Sybase where placeholders are aleged to come at a significant memory cost. You're frequently better off using $dbh->quote() and interpolating the escaped values.

⠤⠤ ⠙⠊⠕⠞⠁⠇⠑⠧⠊

That's strange. under normal circumstances placeholders are much more efficient, especially if you reuse the statement handle returned by $dbh->prepare() and run the query many times. Do you have any links to this problem?

In case you need to use $dbh->quote() it's possible to use Interpolation to make the syntax nicer:

use Interpolation "'" => sub {"'".$dbh->quote($_[0])};
#...
$sql = qq{
  declare \@usrid int, \@sysusrid int
  select \@sysusrid = suser_id($'{$usrname}')
  select \@usrid = $IDVALUE from $ID
  where $IDNAME = 'USR_ID'

  insert into APPUSR (APP_CD, USR_ID, USRNAME, 
   USRFNAME, USRLNAME, FNCGRP_CD, SYSUSR_ID)
  values ('A', \@usrid, $'{$usrname}', 
   $'{$first}', $'{$full_last}', $fncgrp, \@sysusrid)
};
[download]

Jenda


Support Denmark! Defend the free world!

In this particular case you can't use placeholders with Sybase, because the request includes multiple statements in a single batch.

It's probably possible to recode this to avoid multiple statements, however, and thus allow placeholders to be used.

Michael

I'd look to what occurs before sub add_login{. Once perl finds a syntax error, all bets are off. So I would not take any notice of the "@_" error until you fix your syntax error.

One way I use to find the exact line of error is by consequetively putting die "OK" line between lines or blocks of code.

I fail to see how adding die statements would help find a *compile* error. BEGIN { die } might help, but for this type of problem, I usually remove entire chunks from the file until perl -c doesn't find the error. The last thing removed contains the error. Re-add smaller bits until the error comes back if the chunk was too big.

You are right, ikegami. My second paragraph has nothing to do with the original problem. It's the technical I use for runtime error. Thanks for reminding me :-)

---

Open source softwares? Share and enjoy. Make profit from them if you can. Yet, share and enjoy!

My first bet would be a missing/extra quote somewhere.

... could be an extraneous opening parenthesis.

#!/usr/bin/perl

({

  sub add_login{

      my ($var) = @_;
      #...
  }

}
[download]

At least, this produces a rather similar error:

$ perl -c <629906.pl 
syntax error at - line 5, near "sub add_login"
Can't use global @_ in "my" at - line 7, near "= @_"
- had compilation errors.
[download]