Re^4: Using pattern match

Thanks akho. I ended up with this, can you please advise?

#!/usr/bin/perl -w

use strict;

# builtin triggers
my %triggers;

# add triggers from params
my $trigger_name = shift @ARGV;
my $trigger_action_str = shift @ARGV;

$triggers{$trigger_name} = sub { eval $trigger_action_str; };

my $buff = "You are fired!";

foreach my $trigger ( keys ( %triggers ) )
{
  if ( $buff =~ /$trigger/ )
  {
    print &{$triggers{$trigger}};
  }
}
[download]

If I try:
perl triggers2.pl "You are (\w+)." "\"You are: $1\""
I get:
You are: fired

Correct. You see, I just have to add escaped quotes on the command line. But is this one a good way to go, pls?

Cheers,

tceng

Comment on Re^4: Using pattern match Select or Download Code

Replies are listed 'Best First'.
Re^5: Using pattern match by akho (Hermit) on Aug 10, 2007 at 15:46 UTC
You can add the quotes in `sub`'s definition. This is not a very good idea for the same reasons as my `eval`-based solution above: it's insecure (there was a comment above about that) and the interface (the way you call `triggers.pl`) depends on the implementation in weird ways (the user has to use numbered variables). This is ok if you just want to learn about dispatch tables, but production code should be better designed.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^5: Using pattern match
by akho (Hermit) on Aug 10, 2007 at 15:46 UTC

sub

This is not a very good idea for the same reasons as my eval-based solution above: it's insecure (there was a comment above about that) and the interface (the way you call triggers.pl) depends on the implementation in weird ways (the user has to use numbered variables).

This is ok if you just want to learn about dispatch tables, but production code should be better designed.

[reply]
[d/l]
[select]