Re: Confirm an application opens (win32)

That seems like a useful subroutine.

But I'm curious. Since:

        if( $title =~ /$searchString/ )  { $uiFound = 1 }
        last if ( $uiFound >= 1 );
[download]

will always break out of the loop when there's a match, couldn't you refactor the code (assuming that the rest of the logic works) to:?

sub ConfirmUI {
    my $searchString = shift;
    my $uiFound = 0;
    
    for (FindWindowLike()) {        
        my $title = GetWindowText($_);    
        next unless ( $title );
        if( $title =~ /$searchString/ ) {
            $uiFound = 1;
            last;
        }
    }    
    return( $uiFound );
}
[download]

And for that matter, to:

sub ConfirmUI {
    my $searchString = shift;    
    for (FindWindowLike()) {        
        my $title = GetWindowText($_);    
        if ($title and $title =~ /$searchString/) {
            return 1;
        }
    }    
    return 0;
}
[download]

s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/

Comment on Re: Confirm an application opens (win32) Select or Download Code

Replies are listed 'Best First'.
Re^2: Confirm an application opens (win32) by bobf (Monsignor) on Aug 14, 2007 at 02:32 UTC
`if( $title and $title =~ /$searchString/ )` This expression will not work properly if $title is something that evaluates to false, such as the empty string ('') or some form of zero (see True or False? A Quick Reference Guide `</shameless_plug>`), since the first part (`if $title`) will short circuit. Using `defined $title` should fix it. It is unlikely that a window would have such a silly name, but I've learned anything can happen in the wild... In addition, since the regex does not anchor to the beginning and end of the string, it could return an incorrect result if the pattern is a substring of the title. Adding anchors or using 'eq' instead of the regex would tighten up the match so only the exact title would match. Finally, two different windows could have the same title, or an instance of the app could already be open when testing is started. To ensure the window in question opens as a result of the test, it might be useful to compare this list to a list of windows that were open immediately before the test. In other words, call `FindWindowLike()` before the test opens the window in question. Aside: It appears that `FindWindowLike()` can take a regex as a parameter. Is there any reason you can't use that to narrow the search so only possible matches are returned to the 'for' loop? All that said, I agree that this is a nice snippet. Thanks to the OP for posting it. :-)	[reply] [d/l] [select]
Re^2: Confirm an application opens (win32) by technojosh (Priest) on Aug 13, 2007 at 21:48 UTC
yes those both are solid re-works, thanks I am still getting my code minimalist skills up to par...	[reply]