in reply to Re^3: detecting URLs and turning them into links
in thread detecting URLs and turning them into links

Regexp::Common is a wonderful module, but I had the impression that akho was suggesting it as the solution to leave out unwanted trailing characters, like in the example in akho's post:
use Regexp::Common qw( URI );
$message =~ s#^($RE{URI}{HTTP})#<a href="$1">$1</a>#;
$message =~ s#(?<=\s)($RE{URI}{HTTP})#<a href="$1">$1</a>#g;

[download]
My point is only that Regexp::Common does not help with this issue here, because it does not eliminate the trailing punctuation chars (like yours, see today's logs). And it couldn't be differently, because those punctuation chars are allowed in a HTTP URI, so $RE{URI}{HTTP} can't help getting it.

Flavio
perl -ple'$_=reverse' <<<ti.xittelop@oivalf

Don't fool yourself.

Replies are listed 'Best First'.
Re^5: detecting URLs and turning them into links
by moritz (Cardinal) on Aug 24, 2007 at 09:15 UTC
    You are absolutely right about the punctuation. In my use case it just appears virtually never (unless you test it ;-)

    I might consider using a negative lookbehind for punctuation, like so: 

    use strict;
use warnings;
use Regexp::Common qw/URI/;

my  $text = 'http://perl-6.de/,';

if ($text =~ m/($RE{URI}{HTTP}(?<![.,]))/){
    print "Match: $1\n";
}
__END__
# Output:
Match: http://perl-6.de/

    [download]

    I think I'll add this to my CGI scripts as soon as I have write access to the repository again.

    Perl 6 in German -- Difficult Sudoku

[reply]
[d/l]

In Section Seekers of Perl Wisdom