Re: xls2xml -- a "customized general-purpose" tool

I'm generally just as skeptical of code that does it's own XML output as i am of code that rolls it's own XML parsing (both are hard to get right)

Right off the bat i have to wonder: what prevents $sheet->{Name} from containing charcters that require entity replacement? (maybe that's not allowed in XLS files, I have no idea) ... I definitely know it's possible for $name and $path to contain dangerous characters.

Comment on Re: xls2xml -- a "customized general-purpose" tool Select or Download Code

Replies are listed 'Best First'.
Re^2: xls2xml -- a "customized general-purpose" tool by graff (Chancellor) on Aug 28, 2007 at 06:09 UTC
Good points -- thank you. Yes, it's time for me to get better acquainted with a proper xml output module, or at least apply the appropriate module to do entity encoding on those attribute values. (And I must confess to being queasy about the `<d>` element usually just containing character data but sometimes containing `<fullval>` and `<sd>` elements. I probably should shorten the former to `<fv>` and use it in every instance.)	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^2: xls2xml -- a "customized general-purpose" tool
by graff (Chancellor) on Aug 28, 2007 at 06:09 UTC

(And I must confess to being queasy about the <d> element usually just containing character data but sometimes containing <fullval> and <sd> elements. I probably should shorten the former to <fv> and use it in every instance.)

[reply]
[d/l]
[select]