Re^9: 80 characters long

Aixmike,

I have been trying to figure out what you're doing and saying, and I am also stumped. Either you're not very good at telling us what you want, or you don't really know. Sorry if it's harsh, but I've been over this several times (slow day) and you're inconsistent at best.

In your code snippet, you say:

read a line
strip out all CRs (I assume there's only one)
replace each tilde with a CR/LF
save each line in the correct format (not specified)

Okay, but the text before this code that says the tilde must remain and in Notepad there is a CR after each tilde. If you replace the tilde, it is by definition no longer there. So, since your description is contradictory and doesn't match the format you say you want, let's take a look at the sample text you provide and try to deduce what you want. (NOTE: perlmonks may wrap the lines for display.) You say this:

ISA*00*          *00*          *28*9000000454     *ZZ*J00370         *
+070926*0342*U*00401*000489661*0*P*:~
GS*HP*9000000454*J00370*20070926*03421826*489660*X*004010X091A1~
ST*835*489662~
BPR*I*6519.36*C*ACH*CCP*01*075906003*DA*0000194917*1351840597*00454   
+ *01*021000021*DA*304677450*20070926~
TRN*1*EFT2545408*13
[download]

should look like this:

ISA*00*          *00*          *28*9000000454     *ZZ*J00370         *
+070926*0
342*U*00401*000489661*0*P*:~
GS*HP*9000000454*J00370*20070926*03421826*489660*
X*004010X091A1~
ST*835*489662~
BPR*I*6519.36*C*ACH*CCP*01*075906003*DA*00001949
17*1351840597*00454    *01*021000021*DA*304677450*20070926~
TRN*1*EFT2545408*13
[download]

First line (ISA*...) breaks cleanly at 79 characters, in the middle of a "word". The remainder of the line retains its tilde (as do all the lines). Fine. But the second line (GS*...) breaks after 49 characters — when the whole line was only 64 characters! Why? Was it because of the asterisk?

GS*HP*9000000454*J00370*20070926*03421826*489660*X*004010X091A1~
                                                 ^
[download]

The third line (ST*...) is unchanged, but the fourth line (BPR*...) breaks after 48 characters (total line length 109 chars). Again, in the middle of a "word". Um...why?

BPR*I*6519.36*C*ACH*CCP*01*075906003*DA*0000194917*1351840597*00454   
+ *01*021000021*DA*304677450*20070926~
                                                ^
[download]

So, not to put too fine a point on it, do you have any idea what you are talking about?

-dd

Comment on Re^9: 80 characters long Select or Download Code

Replies are listed 'Best First'.
Re^10: 80 characters long by aixmike (Novice) on Oct 01, 2007 at 17:00 UTC
Let me take another stab at explaining this. btw, I do not take your comments personal, I receive an electronic file generated by a third party. below if the fist line of that file. Whe pasting it here the carriage returns do not show up, but there is one following EACH tilde (~). the file contains a bit over 4300 lines similar to this one. the REQUIREMENTS are: 1 - remove all carriage retuns (in vb this would be chr(10) 2 - format the remaining text (including any special characters, and tildes) into 80 characters per line. Breaks in the middle of words or other string combinations is permissible. 3 - This process should be able to be used for other files specified on a command line ie. <perlscriptname> <inputfilename> <outputfilename> As you pointed out the first line breaks at position 79 text::wrap:columns=80 Where column lenght is X - 1 thus 79. the next line as again you point out breaks at position 49 when the entire thing is only 64 positions (WHY) THIS IS MY PROBLEM. I did not understand that the module text::wrap broke on whole words only. If this is the case and it uses spaces to determine a word break, why does the first line work as expected - it may be moot. If you see another approach to achieving my requirements, please let me know. --- Thanks The code immediately below this is where I am at: `#! / usr/bin/perl -w use Text::Wrap qw(wrap); # $name = $ARGV[0]; $name1 = $ARGV[1]; # # open (INFILE, "<$name"); open (OUTFILE, ">$name1"); $Text::Wrap::columns = 80; while (my $row = <INFILE>) { print OUTFILE wrap('','',$row) ; } close (INFILE); close (OUTFILE);` [download] The Inputfile sample -> ISA00 00 289000000454 ZZJ00370 * +0709260342U004010004896610P:~ GSHP9000000454J003702007092603421826489660X004010X091A1~ ST835489662~ BPRI6519.36CACHCCP01075906003DA0000194917135184059700454 + 01021000021DA30467745020070926~ TRN1EFT2545408135184059700454~ DTM40520070925~ N1PRNATIONAL GOVERNMENT SERVICES 00454~ N35151 CAMINO RUIZ~ N4CAMARILLOCA930128645~ REF2U00454~ N1PEGOLDEN LIVINGCENTER FOLEYFI204120517~ N31000 FIANNA WAY~ N4FORT SMITHAR72919~ REFPQ015032~ LX210712~ TS30150322120071231819760.229175.810584.428905.8-2334**91 +75.82604******88905.8~ TS211509.8********24141~ CLP0073294416 07029928919856.96769.14MA20725800001702212~ CASCO94-284.18~ CASPR23720~ NM1QC1BRADYLEOF**HN140079398A~ NM1822GOLDEN LIVINGCENTER FOLEY***XX1538110192~ NM1TT2WPS - TRICARE FOR LIFE***PI000060000~ MIA0*1141.14MA02********3**MA44~ REFEA0073294416~ DTM05020070913~ DTM23 [download]	[reply] [d/l] [select]
Re^11: 80 characters long by ikegami (Patriarch) on Oct 01, 2007 at 20:12 UTC
First, you mean "Line Feed" (chr(10)), not "Carriage Return" (chr(13)). Second, providing the desired output along with a sample input is very useful, especially when you have problems explaining what you want. Finally, we've coverered that Text::Wrap broke on word boundaries on the first day, before you even started using Text::Wrap. Not only did I say "Text::Wrap will only break on a word boundary.", I provided code that broke on the 80th column unconditionally. Let's go back to that code and fix it for the then-unmentioned requirements to remove existing line breaks. `my $text = do { local $/; <> }; $text =~ tr/\n//d; $text =~ s/(.{80})/$1\n/g; $text =~ s/(?!<\n)\z/\n/; print($text);` [download] Usage: `perl script.pl infile > outfile` [download] Or if you want to modify it in-place: `perl -i.bak script.pl file` [download] Output for provided input: ISA00 00 289000000454 ZZJ00370 * +070926034 2U004010004896610P:~GSHP9000000454J00370200709260342182648 +9660X004 010X091A1~ST835489662~BPRI6519.36CACHCCP01075906003DA000019 +491713518 4059700454 01021000021DA30467745020070926~TRN1EFT254540813 +518405970 0454~DTM40520070925~N1PRNATIONAL GOVERNMENT SERVICES 00454~N3515 +1 CAMINO R UIZ~N4CAMARILLOCA930128645~REF2U00454~N1PEGOLDEN LIVINGCENTER F +OLEYFI20 4120517~N31000 FIANNA WAY~N4FORT SMITHAR72919~REFPQ015032~LX210 +712~TS301 50322120071231819760.229175.810584.428905.8-2334**9175.82 +604******* 88905.8~TS211509.8*********24141~CLP0073294416 07029928919856. +96769.14 MA20725800001702212~CASCO94-284.18~CASPR23720~NM1QC1BRAD +YLEOF*** HN140079398A~NM1822GOLDEN LIVINGCENTER FOLEY****XX1538110192~NM1 +TT2WPS - TRICARE FOR LIFE***PI000060000~MIA0*1141.14MA02********3* +*MA44~REF EA0073294416~DTM05020070913~DTM23 [download]	[reply] [d/l] [select]