in reply to Re^4: Deleting lines from named.conf file
in thread Deleting lines from named.conf file

by the way the code you provide me didn't work

Which part didn't work? did you add some print statements to your code to see what each variable holds at each state of execution?

I suspect your main problem is 

my  $targetdomain = <STDIN>;

[download]

$targetdomain is a line from STDIN complete with the newline char. This will match your targetdomain only if it is written as 

zone "foo.bar.com
" {

[download]

and only if you read the file as one chunk and do a multiline match. So change that to 

chomp (my  $targetdomain = <STDIN>);

[download]

to remove the trailing newline.

update: To get help without suspecting, it is best to provide a complete set of data: input, program, expected output, actual output. Do so with the snippet that "didn't work".

--shmem 

_($_=" "x(1<<5)."?\n".q·/)Oo.  G°\        /
                              /\_¯/(q    /
----------------------------  \__(m.====·.(_("always off the crowd"))."·
");sub _{s./.($e="'Itrs `mnsgdq Gdbj O`qkdq")=~y/"-y/#-z/;$e.e && print}

Replies are listed 'Best First'.
Re^6: Deleting lines from named.conf file
by firewall00 (Acolyte) on Nov 10, 2007 at 22:37 UTC
    i mean didnot work didnot perform what i was expected to delete lines from file
    as you provide here : 
    
my $comment = 0;
my $block   = 0;

while(<$in>) {
    if (/^zone\s+"$targetdomain"/) {
        $comment++;
        $block += () = /(\{)/g;
        # print $out '// '.$_;
        next;
    }
    if($comment) {
        $block += () = /(\{)/g;
        s!^!// ! if $comment or $block;
        $block -= () = /(\})/g;
        $comment = 0 unless $block;
    }
    print $out $_ unless $comment;
}

    [download]
    you comment print statement to deny the comments and then use print $out $_ unless $comment; which is completely logical
    but when i run it didn't delete the zone .....,
    i think i need to provide something that written inside a loop to replace the lines of the zone with space like 
    s///;

    [download]

    what do you think about that?
    thanks shmem for your great support
    warm regards
[reply]
[d/l]
[select]
      i think i need to provide something that written inside a loop to replace the lines of the zone with space like 
      s///;

      [download]

      That statement doesn't do anything other than substituting nothing with nothing, which isn't anything you could call something.

      Sample named.conf: 

      options {
        listen-on port 53 { 127.0.0.1; };
        // listen-on-v6 port 53 { ::1; };
        directory       "/var/named";
        dump-file       "/var/named/data/cache_dump.db";
        statistics-file "/var/named/data/named_stats.txt";
        memstatistics-file "/var/named/data/named_mem_stats.txt";
        allow-query     { localhost; };
        forwarders {
            2.3.4.5;
        };
        recursion yes;
};

logging {
        channel default_debug {
                file "data/named.run";
                severity dynamic;
        };
};

zone "." IN {
        type hint;
        file "named.ca";
};

zone "foo.bar.de" {
    type master;
    file "foo-bar";
    allow-transfer {
        1.2.3.4;
        1.2.3.5;
    };
};  
zone "quux.info" {
    type forward;
    forwarders {
        3.4.5.6;
        4.5.6.7;
    };  
};  
zone "blah-fasel.de" {
    type forward;
    forwarders {
        5.6.7.8;
    };  
};  
zone "10.in-addr.arpa" {
    type forward;
    forwarders {
        1.2.3.4;
        2.3.4.5;
        3.4.5.6;
    };  
};  
include "/etc/named.rfc1912.zones";

      [download]

      The following script is used to delete a zone: 

      #!/usr/bin/perl -w 

use strict;

print "please enter the domain name: ";

chomp (my $targetdomain = <STDIN>);

my $file = "named.conf"; # copied to my home folder

rename $file, "$file.bak" or die "Can't rename file '$file': $!\n";

open my $in, '<', "$file.bak" or die "Can't read file '$file': $!\n";
open my $out, '>', $file or die "Can't write file '$file': $!\n";

my $comment = 0;
my $block   = 0;

while(<$in>) {
    if (/^zone\s+"$targetdomain"/) {
        $comment++;
        $block += () = /(\{)/g;
        # print $out '// '.$_;
        next;
    }
    if($comment) {
        $block += () = /(\{)/g;
        s!^!// ! if $comment or $block;
        $block -= () = /(\})/g;
        unless ($block) {
            $comment = 0;
            next;
        }
    }
    print $out $_ unless $comment;
}

      [download]

      We delete the zone "quux.info" using that script, named 'zonedel.pl': 

      qwurx [shmem] ~ > perl zonedel.pl
please enter the domain name: quux.info

      [download]

      The zone file (named.conf) is now: 

      options {
        listen-on port 53 { 127.0.0.1; };
        // listen-on-v6 port 53 { ::1; };
        directory       "/var/named";
        dump-file       "/var/named/data/cache_dump.db";
        statistics-file "/var/named/data/named_stats.txt";
        memstatistics-file "/var/named/data/named_mem_stats.txt";
        allow-query     { localhost; };
        forwarders {
            2.3.4.5;
        };
        recursion yes;
};

logging {
        channel default_debug {
                file "data/named.run";
                severity dynamic;
        };
};

zone "." IN {
        type hint;
        file "named.ca";
};

zone "foo.bar.de" {
    type master;
    file "foo-bar";
    allow-transfer {
        1.2.3.4;
        1.2.3.5;
    };
};
zone "blah-fasel.de" {
    type forward;
    forwarders {
        5.6.7.8;
    };
};
zone "10.in-addr.arpa" {
    type forward;
    forwarders {
        1.2.3.4;
        2.3.4.5;
        3.4.5.6;
    };
};
include "/etc/named.rfc1912.zones";

      [download]

      Running 'diff -uNw named.conf named.conf.bak' shows: 

      --- named.conf  2007-11-11 00:25:18.000000000 +0100
+++ named.conf.bak      2007-11-11 00:18:17.000000000 +0100
@@ -46,6 +46,13 @@
        1.2.3.5;
     };
 };
+zone "quux.info" {
+    type forward;
+    forwarders {
+       3.4.5.6;
+       4.5.6.7;
+    };
+};
 zone "blah-fasel.de" {
     type forward;
     forwarders {

      [download]

      Please let me know if that solution doesn't work for you. In that case, please provide a full set of files as I have done.

      --shmem 

      _($_=" "x(1<<5)."?\n".q·/)Oo.  G°\        /
                              /\_¯/(q    /
----------------------------  \__(m.====·.(_("always off the crowd"))."·
");sub _{s./.($e="'Itrs `mnsgdq Gdbj O`qkdq")=~y/"-y/#-z/;$e.e && print}
[reply]
[d/l]
[select]

        many thanks for your support


        first the script is running will but it has 2 issues :-
        the first issue when i want to delete the first zone like that 
        zone "foo.com" {
type master 
file path to the zone 
};

zone "blah.com" {
type master 
file path to the zone 
};

zone "bar.com" {
type master 
file path to the zone 
};

        [download]
        if i want to delete the first zone "foo.com" the file doesn't change !!!
        the second issue if i want to delete any zone in the middle of the file like "blah.com"there is
        a newline created instead of deleted zone the output is like this 
        zone "foo.com" {
type master 
file path to the zone 
};


zone "bar.com" {
type master 
file path to the zone 
};

        [download]
        as u see a white space is created in the place of the deleted zone ,, so i want to eliminate this new line
        i think it will done by making the print statement to print the file with a shifted instead of the deleted zone .
        finally i want to understand the $comment variable is here what we provide such variable
        i knew that $block to count the brackets level and the $comment in the our old example was provided to count the comment level
        so what is the value of this variable here
        and Really am thankful for you
[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom