in reply to Re^4: Making an automatic counter adder for all webpages
in thread Making an automatic counter adder for all webpages
Regarding how to get the page name, you provided little insight about how a page name is "generated"; in any case, whatever your approach (the one suggested by Fletch, or the ALTER TABLE one), you have to find some way to decide which counter you want to increase. Which means that this is not a problem tied to this specific solution. If the page name is tied to the current script, anyway, you might benefit from the contents of either $0 (perlvar) or of __FILE__ (perldata), whatever applies best to your case.
I'd make the "pagename" column a primary key for the table, and just do something like this:
If the record for the given page does not exist, it's created and the counter is initialised to 0. If it already exists, the INSERT fails due to the fact that the pagename column is a primary key, and you can't have two records with the same primary key. In either case, after the eval you're sufficiently confident* that a record for the given page actually exists in the table.# Unconditionally try to create a new record. eval { $db->do('INSERT INTO counters (pagename, pagecounter) VALUES ($, 0) +', undef, $pagename); }; # Unconditionally increase the counter $db->do('UPDATE counters SET pagecounter = pagecounter + 1 WHERE pagen +ame = ?', undef, $pagename);
After this, you increase the counter. If the record was just created, it is correctly bumped to 1. In the other case, it is simply increased, which is what you want.
No checks (the RDBMS does these for you), no race conditions... maybe a little dirt? Acceptable, IMHO.
* "sufficiently confident" means that the INSERT could fail for other reasons apart the field being there. If all the rest is working properly, than you can be confident that after the eval you'll have something to increase in that table.
Hey! Up to Dec 16, 2007 I was named frodo72, take note of the change! Flavio
perl -ple'$_=reverse' <<<ti.xittelop@oivalf
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^6: Making an automatic counter adder for all webpages
by Nik (Initiate) on Dec 23, 2007 at 11:38 UTC | |
by polettix (Vicar) on Dec 23, 2007 at 14:24 UTC | |
by Nik (Initiate) on Dec 24, 2007 at 10:34 UTC | |
by polettix (Vicar) on Dec 24, 2007 at 12:45 UTC | |
|