I consider that idiom fairly standard, so I wouldn't hesitate using it in general. But others have shown better ways of solving this particular problem.

On a general note, consider DBIx::Simple if you want a more elegant interface on top of DBI.

/J