in reply to SOLVED Removing characters

# replace (s///) all (g) non word-characters \W with nothing
$mystring = $mystring += $_=~ s/\W//g;
print lc($mystring);  # lowercase

[download]

Regards,
svenXY

update: as said a couple of times by now, please consider reading perlop on tr/// and s/// and m/// as well as perlre on regular expressions. Otherwise you won't have much fun with Perl. And I can swear you: it IS fun if you get past the first few lessons...

update 2: $mystring = $mystring += $_=~ s/\W//g; is wrong. Please see my later post for a working example and forgive the error.

Replies are listed 'Best First'.
Re^2: Removing characters
by Slug (Acolyte) on Jan 22, 2008 at 15:22 UTC
    Thanks for the help so far everybody!

    I tried this, $mystring seems to return 31 instead of the formatted string.

    
open (READFILE, "<poem.txt") || die "Couldn't open file: $!";
$buffer = "";
$lines = 0;

while(<READFILE>) {
    $chars += length($_);
    $lines++ ;
    my @word = split " ", $_;
    $word_cnt += @word;
    chomp($mystring);
$mystring = $mystring += $_=~ s/\W//g;
     
}

print ("Lines: $lines\n");
print ("Words: $word_cnt\n");
print ("Characters: $chars\n");

print lc("$mystring\n");

    [download]
[reply]
[d/l]

      Because despite being told that s modifies the string it's working on in place you persist in attempting to use its return value (the number of substitutions made) as something meaningful ($_ contains the converted string; you would want to append the contents of $_ to your accumulated buffer instead). Not to mention you're still trying to use + as a concatenation operator rather than the correct . operator.

      Update: Oop, you're using s/// instead of tr/// but the point's the same (that it modifies the string in place and doesn't have a meaningfull (in this instance) return value). Wording changed accordingly.

      And it's just been pointed out to me that that line wasn't yours, which only partly excuses you in that you cargo cultly included it without understanding that it was doing the very thing you'd already been warned about.

      The cake is a lie.
      The cake is a lie.
      The cake is a lie.

[reply]
[d/l]
[select]
        Fletch++, yep, I was wrong on that one... I only tested the s/.../...stuff on the command-line without really checking what the whole line looked like.
        Sorry to have confused.
        Regards,
        svenXY
[reply]
      Hi,
      almost there... 
      #!/usr/bin/perl
use strict;
use warnings;

my ($chars, $lines, @word, $word_cnt, $mystring, $bla );

$lines = 0;

while(<DATA>) {
    $chars += length($_);
    $lines++ ;
    my @word = split " ", $_;
    $word_cnt += @word;
    ($bla = $_) =~ s/\W//g; # assign the converted string of $_ to $bl
+a
     $mystring .= lc($bla); # concatenate lowercase $bla to $mystring
}

print ("Lines: $lines\n");
print ("Words: $word_cnt\n");
print ("Characters: $chars\n");

print("Total String: $mystring \n");

__DATA__
Hey, diddle, diddle,
The cat and the fiddle.

      [download]

      Regards,
      svenXY
[reply]
[d/l]

In Section Seekers of Perl Wisdom