in reply to uninitialized value error

First, let's make your code readable by running it through perltidy:

#!/usr/bin/perl # use strict; use warnings; use List::Util q{first}; sub search_phrase { my @array; my ($inFile, @phrases) = @_; my $lastPhrase = $phrases[-1]; open my $inFH, q{<}, $inFile or die qq{open: $inFile: $!\n}; my @lines = <$inFH>; close $inFH or die qq{close: $!\n}; foreach my $phrase (@phrases) { my $rxPhrase = qr{\Q$phrase\E}; my $lineNo = first {$lines[$_] =~ $rxPhrase} 0 .. $#lines; unless (defined $lineNo) { #print "-1"; # print qq{$phrase: not found in sequence\n}; next; } print "" if ($lines[$lineNo] =~ m{\Q$lastPhrase\E\s*(\d*)}); push (@array, $1); $lineNo++; splice @lines, 0, $lineNo; } return (@array); } my $file_n = "665172.data"; my $phrase1 = "total rejected rows:"; my $phrase2 = "total rejected recors:"; my $phrase3 = "rejectb:"; my $phrase4 = "total rejected rows:"; my @newarray = search_phrase( $file_n, $phrase1, $phrase2, $phrase3, $phrase4 ); my $count = ($#newarray); $newarray[$count] =~ s/\s+//g; if ((($#newarray + 1) >= 1) && ($newarray[$count] gt 0)) { print "$newarray[$count]\n"; } else { print "-1\n"; }

Next, when I try running your code, it works fine, and you say it works fine for you, except when you ru it on a server.

So the obvious question (but one that I'll ask anyway) is, "What's the difference from your workstation and the server?" You're only using List::Util -- I imagine it's installed on the server, and the same version number. Is the data file the same?

Now onto the fun part: picking out stylistic miscues.

Those are my thoughts. What do you think?

Update: As both Narveson and wfsp have pointed out, for reads the entire file in, so doesn't achieve the goal I was reaching. Instead, use while. Oops.

Alex / talexb / Toronto

"Groklaw is the open-source mentality applied to legal research" ~ Linus Torvalds

Replies are listed 'Best First'.
Re^2: uninitialized value error
by Narveson (Chaplain) on Jan 30, 2008 at 21:16 UTC

    Now onto the fun part: picking out stylistic miscues.

    • open INPUT is traditional, it's true, but open my $inFH is far better. The traditional INPUT is global, my $inFH is lexical. For the drawbacks of global variables and the advantages of lexicals, see e.g. Conway, Perl Best Practices.
    • Processing a file one line at a time is of course a good idea. The way to do it (and this is traditional) is while (my $thisLine =<$inFH>)