Re: Need Critique (Good or Bad)

In addition to all of the above, I'd suggest taking all of your $line testing and putting it in one procedure. This provides two benefits:

You can define $sql once, at the top, and have a single

     my $statement = $db_handle->prepare($sql)
                    or die "Couldn't prepare query '$sql': $DBI::errst
+r\n";
     $statement->execute()
                    or die "Couldn't execute query '$sql': $DBI::errst
+r\n";
[download]

after the conditionals if you have a non-null $sql.

The general flow of logic will be more evident

Comment on Re: Need Critique (Good or Bad) Download Code