Breaking up a string?

Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

Replies are listed 'Best First'.
Re: Breaking up a string? by BrowserUk (Patriarch) on Feb 19, 2008 at 15:13 UTC
`$string = join'', map int rand 10, 1 .. 40;; @array = unpack '(A6)*', $string;; print for @array;; 264811 795150 543830 002804 757197 623650 5346` [download] Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error. "Science is about questioning the status quo. Questioning authority". In the absence of evidence, opinion is indistinguishable from prejudice. "Too many [] have been sedated by an oppressive environment of political correctness and risk aversion."	[reply] [d/l]
Re: Breaking up a string? by Fletch (Bishop) on Feb 19, 2008 at 14:45 UTC
Maybe if you showed the purported "ugly and inefficient" code someone could help you clean it up . . . See also How (Not) To Ask A Question. The cake is a lie. The cake is a lie. The cake is a lie.	[reply]
Re: Breaking up a string? by olus (Curate) on Feb 19, 2008 at 15:18 UTC
`use strict; use warnings; my $s="whatever your string looks like"; my @b = $s =~ /.{6}/g; push @b, substr($s, - (6 - int(length($s)/6) ) ); $\="\n"; print foreach @b;` [download] outputs `whatev er you r stri ng loo ks lik e` [download]	[reply] [d/l] [select]
Re: Breaking up a string? by lidden (Curate) on Feb 19, 2008 at 15:53 UTC
While you most likely want what BrowserUk said above, here is one that use the fact that your input is numerical. `use bigint; my $num = 111111555555123456; my @array; while( $num ){ unshift @array, $num % 1_000_000; $num /= 1_000_000; } print "@array\n";` [download] Though it will be eating leading zeros.	[reply] [d/l]
Re: Breaking up a string? by stiller (Friar) on Feb 19, 2008 at 14:45 UTC
How inefficient is it? How ugly is your code? How big is your string? What have you tried? Did you try a regex? What did it look like?	[reply]
Re^2: Breaking up a string? by Anonymous Monk on Feb 19, 2008 at 14:48 UTC
What I tried was using substr to get the first 6 chars, reversing the string, chop'ing it 6 times and reversing it again - all in a repeating loop. There has to be a better way than that :\	[reply]
Re^3: Breaking up a string? by kyle (Abbot) on Feb 19, 2008 at 15:36 UTC
Here's a somewhat more Perlish solution: `my @sets_of_six = ( $s =~ m{ (.{6}) }xmsg );` [download]	[reply] [d/l]
Re^4: Breaking up a string? by BrowserUk (Patriarch) on Feb 19, 2008 at 15:52 UTC
Re^5: Breaking up a string? by kyle (Abbot) on Feb 19, 2008 at 16:21 UTC
Re^3: Breaking up a string? by stiller (Friar) on Feb 19, 2008 at 14:53 UTC
If you got your six characters, why did you perform that reverse - 6 times chop - reverse operation on it? Can't you post a little example code that runs, some example input and the result you get, with an explanation on how your result differ from what you want?	[reply]
Re^4: Breaking up a string? by Anonymous Monk on Feb 19, 2008 at 14:57 UTC
Re^5: Breaking up a string? by stiller (Friar) on Feb 19, 2008 at 15:12 UTC
Some notes below your chosen depth have not been shown here
Re: Breaking up a string? by johngg (Canon) on Feb 19, 2008 at 19:53 UTC
Given that the OP mentions the `substr`, `chop` and `reverse` methodology I'm wondering if the requirement is to produce an array of arrays of six numbers. Perhaps this is what's required. `use strict; use warnings; use Data::Dumper; my $string = join q{}, map { int rand 10 } 1 .. 24; my @AoAofSixes = map { [ split m{} ] } $string =~ m{.{6}}g; print Data::Dumper->Dumpxs( [ \ @AoAofSixes ], [ q{AoAofSixes} ] );` [download] The output. `@AoAofSixes = ( [ '1', '9', '6', '8', '4', '7' ], [ '1', '5', '1', '9', '8', '5' ], [ '9', '6', '6', '0', '1', '1' ], [ '3', '8', '3', '2', '5', '8' ] );` [download] It's possible I'm barking up the wrong tree but it would explain the why of the "really ugly and inefficient" code. Cheers, JohnGG Update:* Fixed typo	[reply] [d/l] [select]