in reply to Subroutines within if statements

"a" is always true, so your code always calls addlinks().

In Section Seekers of Perl Wisdom