More Code review

I agree with all of this, but having the review open to people above a certain XP is problematic, it would make the code not entirely peer review. Which in industry I've found a bad thing, it lacks democracy for one thing. I know lots of really good developers with lower XP than me.

But then what do you do? As a first pass, this seems to be a compromise but a good starting place¹. IMHO FWIW

--

Brother Frankus.

1. Of course I'm perhaps being presumptuous to assume a Friar would get this priviledge ;-)

Comment on More Code review

Replies are listed 'Best First'.
Re: More Code review by little (Curate) on Mar 26, 2001 at 22:32 UTC
There was also long ago a thread discussing the question if the "perl guru's" like Wall, Schwartz, Christiansen (forgive me my funny and short list, it's not meant as anything else than a short list) should get tons of XP in advance, but as far as I remember all agreed that everyone has to earn his XP. And very professional perl coders might say welcome to those who ask them in any other way (just as merlyn does by stating that he welcomes questions about questionable code by e-mail). But I would recommend to NOT TO LET MONKS decide whether a monk is allowed to access this section or not. Just keep it simple. Have a nice day All decision is left to your taste	[reply]

Replies are listed 'Best First'.

Re: More Code review
by little (Curate) on Mar 26, 2001 at 22:32 UTC

All decision is left to your taste

[reply]