Unnecessary copying of settings on every page render

I was looking at system settings, %HTMLVARS, and set_htmlvars... And the picture which emerges is that certain parameters are defined with one name in system settings and used in Everything/HTML.pm with another name. This "renaming" is done in set_htmlvars. For example, permissionDenied_node is loaded into %HTMLVARS from system settings, but then is copied to a new %HTMLVARS entry, permission_denied. Everything/HTML.pm has been modified to use the new names. The old names now only occur in system settings, where they're defined, and in set_htmlvars, where they're copied to new names.

Why was this done, rather than simply continuing to use the old names?

It seems to me that we can improve clarity and performance by defining the new parameters directly in system settings; then we don't need set_htmlvars to copy anything. Is there any reason we shouldn't do this?

A word spoken in Mind will reach its own level, in the objective world, by its own weight

Comment on Unnecessary copying of settings on every page render Select or Download Code

Replies are listed 'Best First'.
Re: Unnecessary copying of settings on every page render by jdporter (Paladin) on Nov 05, 2008 at 15:05 UTC
FWIW, I created a pair of patches for this: system settings - (patch) and set_htmlvars - (patch). NB, They should be applied strictly in that order.	[reply]