Re: Problems With Tab Delimited Files

I noticed a couple other "tidy code" things you might want to consider.

use strict; and use warnings; will help you find various things (though, not this bug). When you do this, you'll have to start declaring your variables (e.g., my $day; or my @dayvalues;.)
the open statement could benefit from being the 3-parameter version:
```
open PYCFILE, "<", $filename or die ...
[download]
```
It might be easier to read the file one line at a time rather than slurp the whole thing up into an array and parse the array one line at a time:
```
while (my $line=<PYCFILE>) ...
[download]
```
You only need chomp to remove the newline at the end of a line. You don't have to worry about doing it for each token read from shift or each value pulled from an array.

HTH

--
Wade

Comment on Re: Problems With Tab Delimited Files Select or Download Code

Replies are listed 'Best First'.
Re^2: Problems With Tab Delimited Files by tom10animal (Monk) on Mar 26, 2008 at 21:11 UTC
Thank you for the help. I would like to clarify a few things though. First, generally I do `use warnings;` and `use strict;`. In my larger script that I coppied those smaller chunks of code from, everything was declared. Thank you for pointing it out though, as had I not known that I should be declaring variables, I would have started right away after your comment. Second, I realize (and have been taught) that indentation is better for the eyes and I appologize for my lazyness. As far as the overuse of `chomp`, I was just trying to be careful, but I now see that it was not nescecary. Thank you for your suggestions.	[reply] [d/l] [select]

Replies are listed 'Best First'.

use warnings;

use strict;

chomp