Re^2: faulty expression prob

You removed the check that prevented the method tag from being called on an undefined value.

$dist = $rh->tag('DISTRIBUTION');
[download]

should be

$dist = $rh && $rh->tag('DISTRIBUTION');
[download]

Also,

$pkg->{DIST} = $dist ? $dist : undef
[download]

can be written as

$pkg->{DIST} = $dist || undef
[download]

Comment on Re^2: faulty expression prob Select or Download Code

Replies are listed 'Best First'.
Re^3: faulty expression prob by perl-diddler (Chaplain) on Apr 03, 2008 at 23:17 UTC
Um...somewhere along the line, someone dropped a "$" before "undef"..."$undef" != undef, but $undef = 'undef''; In answer to next Q, I did want assignments -- they needed to be evaluated or done left-to-right, where the 'right' side isn't done if the left side fails... If I wanted to use "==" instead of assignment, I would have preferred '&&' over 'and'. I try to use 'and' && 'or' when I don't want them interfering with an assignment.	[reply]
Re^4: faulty expression prob by ikegami (Patriarch) on Apr 04, 2008 at 00:32 UTC
where the 'right' side isn't done if the left side fails... That's what `$rv &&` does. Update: Hum, at first, I thought you you were disagreeing with what I posted, but I think you were just confirming what I said.	[reply] [d/l]