($outstring = $instring) =~ tr/-/_/;

This might be a little better.

The tr (translate) operator does exactly what you are asking for. man perlop for more info.

Also, in Perl, strings and arrays are not interchangible. $string[2] does not get you the third letter of $string...it gets you the third element of the array @string, a different beast entirely.