in reply to Re: Ranking files, largest to smallest
in thread Ranking files, largest to smallest
Given the assumption of homework...
#!/usr/local/bin/perl use strict; use warnings; use CGI qw/:standard/; use CGI::Carp qw/fatalsToBrowser/;
Strict/warnings: good habit to start with. Also, good to use "standard", tested modules (CGI, CGI::Carp) rather than re-inventing wheel.
my $wrestlerdir = '/home/ewexpert/public_html/rosterrank'; open(FILE, "$wrestlerdir/wrestlerlist.txt"); my @lines = <FILE>; chomp (@lines = <FILE>); close(FILE);
As mentioned by the previous poster, the first @lines=<FILE> line is slurping all of your data, and then being overwritten. Use the second line. Additionally, the indenting between the open and close is a little misleading. I understand why you did it, but the structure implies that @lines may not be in scope after the close(), especially since it is being declared with my.
foreach my $test (@lines) { open my $fh, "<", "$wrestlerdir/$test.total" or die "Can't open @lines +.total $!"; my @total = <$fh>; }
print header, start_html('Rankings: '), (@lines), end_html;
This is using "Rankings: " as the page title, and nothing more. You are then printing all of the contents of the list of files, without any HTML formatting (at least in this version of your program), and then the HTML terminator. See the previous set of comments, and the last respondent. I think they may go straight to the heart of the issues in your solution.
Good luck, and ask if you have any more questions on this.
--MidLifeXis
|
|---|