DBI Sqlite insert function

ScOut3R has asked for the wisdom of the Perl Monks concerning the following question:

Hey There Monks, i'm wokring on a small script which interacts with an sqlite database. I'd like to make a function which inserts values in a certain table. Here's the function:

sub insert_element {
    my $table = pop @_;
    my @values = @_;
    $db->do("insert into '$table' values ('@values')") or my $error = 
+$db->errstr; if (defined($error)) { die syslog('info',"insert: $error
+"); }
}
[download]

I have problems with the @values array, because the $db->do function wont split it into separate values. Is there a good way to separate it automatically? I'd like to insert full rows, so i'll pass as many values to this function as many columns are in the table. Thank You for your help!

Comment on DBI Sqlite insert function Download Code

Replies are listed 'Best First'.
Re: DBI Sqlite insert function by olus (Curate) on Jun 30, 2008 at 18:03 UTC
In order to expand `@values` you should look at join. Still, I would suggest you to use a different approach regarding passing values to database queries. You can start by looking at What are placeholders in DBI, and why would I want to use them?.	[reply] [d/l]
Re^2: DBI Sqlite insert function by ScOut3R (Sexton) on Jul 01, 2008 at 13:57 UTC
Ah sorry, i meant to split @values into separate values.	[reply]
Re^3: DBI Sqlite insert function by olus (Curate) on Jul 01, 2008 at 15:24 UTC
From what I understand from your post, you want to convert the array `@values` to a string that has the array's values comma separated, as that would be the correct SQL syntax. So, if you have an array: `@values = ( 1, 2, 3 );` [download] and you want to put that into the SQL query you'll have to `join` the values: `my $str_values = join(', ', @values); # $str_values is now '1, 2, 3' ... $db->do("insert into $table values ($str_values)") ... ...` [download] Still, I strongly advise the reading of the info on placeholders.	[reply] [d/l] [select]
Re^4: DBI Sqlite insert function by ScOut3R (Sexton) on Jul 01, 2008 at 16:31 UTC