Re^4: Customizable login page? (precog)

I'm unsure how to parse your first sentence. However, I think you may be pointing out that the login form has a node_id=XXXX hidden inside of it in order to determine which node gets loaded when one submits the form. Obviously, this node_id can't be set to blazar's personal favorite node's ID if we don't know yet that blazar is the monk who is going to use the form to log in. Which belies the "easy to implement" claim (since the point seems to be to avoid the extra round-trip which blazar must lack the patience for since there are so many ways to get to your favorite node with a single click after login and it isn't even hard to use Free-Nodelet JavaScript to eliminate the need to click).

But it would be possible for the heart of the login code to note that $q->param('node_id') is login and override it (for POST requests). But that also strikes me as a rather sloppy hack. Perhaps not unacceptably crufty, though.

- tye

Comment on Re^4: Customizable login page? (precog) Download Code

Replies are listed 'Best First'.
Re^5: Customizable login page? (precog) by ysth (Canon) on Aug 07, 2008 at 16:06 UTC
Re: parse, blazar seemed to be arguing that I was requiring an extra "go to" step. But his description of his desired flow left off the equivalent step of: "go to"-some-page-with-a-login-form. That's only a hack in that logging in via the nodelet login form on the login page arguably does the "wrong thing". Otherwise, there's nothing wrong with it, and it doesn't seem that bad to me. -- Online Fortune Cookie Search Office Space merchandise	[reply]
Re^5: Customizable login page? (precog) by blazar (Canon) on Aug 07, 2008 at 09:22 UTC
the point seems to be to avoid the extra round-trip which blazar must lack the patience* for since there are so many ways to get to your favorite node with a single click after login* (Additional emphasis added by me) I personally believe that I'm doing my best to become a better person under that respect, since it is a virtue I've often complained not to possess to a high enough degree. it isn't even hard to use Free-Nodelet JavaScript to eliminate the need to click D'Oh! I constantly keep forgetting about the Free Nodelet. Of course, my complete ignorance of JS does play a role in this: indeed one single thing that really makes me want to possibly learn it is to hack PM! Anyway, this is a simple enoug task that I'm sure I can ask some knowledgeable friend, ad he would come up with a ready made solution. Thanks! Incidentally, I apologize for having made gratuitous assumptions on how easy it would be to add the feature I'm after, without actually knowing the codebase: of course it would require, if nothing else, the creation of a new column in the database holding each monk's favourite starting node... `--` If you can't understand the incipit, then please check the IPB Campaign.	[reply] [d/l]
Re^6: Customizable login page? (settings) by tye (Sage) on Aug 07, 2008 at 17:12 UTC
Just FYI, user settings are stored as a serialized hash in a large text field so no database schema changes are required for adding another user setting. - tye	[reply]