in reply to sql-o-matic

my $dbh=DBI->connect($dsn,$opts{user}{value},$opts{password}{value}) |
+| die($!);

[download]

The  || operator has higher precedence than the  = operator so you should either enclose the assignment in parentheses or use the lower precedence  or operator.

According to the DBI manual:

If the connect fails (see below), it returns "undef" and sets both $DBI::err and $DBI::errstr. (It does not explicitly set $!.) You should generally test the return status of "connect" and "print $DBI::errstr" if it has failed.

So that line should be: 

my $dbh = DBI->connect( $dsn, $opts{ user }{ value }, $opts{ password 
+}{ value } ) or die $DBI::errstr;

[download]
    crash_n_burn() if $cl_part=~/^-h$|^--help$|^-h$/i;

[download]

If the first  ^-h$ pattern doesn't match what makes you think that the second one will? 

  $s_insert=<<EOT;
/*
  Insert SP for $table
*/
drop procedure if exists insert_$table;
delimiter //
create procedure insert_table (
EOT

[download]

Shouldn't that be: 

  $s_insert=<<EOT;
/*
  Insert SP for $table
*/
drop procedure if exists insert_$table;
delimiter //
create procedure insert_$table (
EOT

[download]

Replies are listed 'Best First'.
Re^2: sql-o-matic
by ambrus (Abbot) on Sep 16, 2008 at 14:26 UTC 
        my $dbh=DBI->connect($dsn,$opts{user}{value},$opts{password}{value
+}) || die($!);

    [download]
    The || operator has higher precedence than the = operator so you should either enclose the assignment in parentheses or use the lower precedence or operator.

    Wrong. As die($!) never returns, it doesn't matter which way you write it.

[reply]
[d/l]
[select]
      Sorry but, even if your phrase holds a truth value, you are wrong in many levels.
      1. die can be overriden in one way or another, and start returning something!
      2. my $c = 'shat'; eval { $c = DBI->connect(xxx) || die } keeps the old value in $c (instead of putting undef there, like or would do), and this may not be what the user wants...
      3. it would be nice if people grew accostumed not to mix = and || inadvertently.
      So, my $c = DBI->connect(xxx) or die is the right idiom for good reasons.
      []s, HTH, Massa (κς,πμ,πλ)
[reply]
[d/l]
[select]

In Section Code Catacombs