Re: Simple binary data to JS string literal converter

while ($s)
should be
while (length($s))

It would also be nice if the wrapping occurs after at most 60 characters, instead of after at least 60 characters (with no maximum!)

Comment on Re: Simple binary data to JS string literal converter Select or Download Code

Replies are listed 'Best First'.
Re^2: Simple binary data to JS string literal converter by blazar (Canon) on Sep 16, 2008 at 11:31 UTC
`while ($s)` should be `while (length($s))` I personally believe that you're partially right: after all I may end up with `$s eq "0"`! D'oh! But then length would leave me with an `uninitialized` warning on the last iteration. Thus I'd use defined instead: worse luck, if it were not for 0 being a valid octal digit, I wouldn't have needed it in `!defined $s` above, either! It would also be nice if the wrapping occurs after at most 60 characters, instead of after at least 60 characters (with no maximum!) You're probably right: but to be fair, the splitting was more of an afterthought than anything else. I was primarily concerned with the conversion, and I hope not to have left errors there. (Now, if I had some spare time, I would make this into a Perl string literal converter, and then use eval to check... Perhaps, after lunch I'll do! ;) `--` If you can't understand the incipit, then please check the IPB Campaign.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^2: Simple binary data to JS string literal converter
by blazar (Canon) on Sep 16, 2008 at 11:31 UTC

while ($s)
should be
while (length($s))

I personally believe that you're partially right: after all I may end up with $s eq "0"! D'oh! But then length would leave me with an uninitialized warning on the last iteration. Thus I'd use defined instead: worse luck, if it were not for 0 being a valid octal digit, I wouldn't have needed it in !defined $s above, either!

It would also be nice if the wrapping occurs after at most 60 characters, instead of after at least 60 characters (with no maximum!)

You're probably right: but to be fair, the splitting was more of an afterthought than anything else. I was primarily concerned with the conversion, and I hope not to have left errors there. (Now, if I had some spare time, I would make this into a Perl string literal converter, and then use eval to check... Perhaps, after lunch I'll do! ;)

--
If you can't understand the incipit, then please check the IPB Campaign.

[reply]
[d/l]
[select]