Re^2: Unshift and push inside of map operation.

while (my $item = shift @toprocess)
[download]

will fail if one of the items evaluates to false. You want to check "if an item has been returned", not "if an item has been returned and its true". Fix:

while (my ($item) = shift @toprocess)
[download]

A list assignment in scalar context returns the number of items being assigned.

Update: Oops, I'm used to dealing with iterators that return () when out of data. As per tye's reply, my fix makes things worse. The following allows false values without introducing an infinite loop:

while (@toprocess) {
   my $item = shift @toprocess;
[download]

Due to the extra complexity, it might make more sense to the simpler original if it's safe.

Comment on Re^2: Unshift and push inside of map operation. Select or Download Code

Replies are listed 'Best First'.
Re^3: Unshift and push inside of map operation. (test) by tye (Sage) on Sep 23, 2008 at 05:08 UTC
I suspect you haven't tested this. It might seem reasonable to assume that shift on an empty array returns an empty list. However, my testing on Perl 5.8.8 and 5.10 shows that `shift @empty` returns a single undef, not an empty list and your example produces an endless loop. - tye	[reply]
Re^4: Unshift and push inside of map operation. (test) by JadeNB (Chaplain) on Sep 23, 2008 at 18:17 UTC
However, my testing on Perl 5.8.8 and 5.10 shows that `shift @empty` returns a single undef, not an empty list This is actually the documented behaviour, not (just) a quirk of implementation: shift.	[reply] [d/l]