( The OP is no longer what it was when I replied. The code snippet was changed, and a second code snippet was added. )

There are no syntax errors.

>perl -c script.pl
script.pl syntax OK
[download]

But that doesn't mean it does what you want it to do.

@logging='find . -name cynlogging.properties';
should be
@logging=`find . -name cynlogging.properties`;

And you need to remove the newlines returned by find by adding
chomp @logging;

Finally, you never write your changes to the file.

Update: Missed one.

Your inner loop modifies $prop repeatedly, but the loop variable is the default $_.
$prop =~ s/DEBUG_MIN/WARN/g;
should be
$_ =~ s/DEBUG_MIN/WARN/g;
which is the same as just
s/DEBUG_MIN/WARN/g;

Rather than using an external, non-portable program, you can use File::Find - it comes with Perl, and works pretty well. It also seems like you were trying to imitate the functionality of Tie::File without actually using it - so that didn't work either. Here's an example of how you might use those two to do what you want:

#!/usr/bin/perl -w
use strict;
use File::Find;
use Tie::File;

find(\&wanted, '/opt/tivoli/itcam/was/DC/');

sub wanted {
    return unless /cynlogging.properties/;
    tie my @file, 'Tie::File', $_ or die "$_: $!\n";
    s/DEBUG_MIN/WARN/g for @file;
    untie @file;
}
[download]

The second script is close enough to the first one that I'm going to take the easy way out and say "Solution is trivial, and left as an exercise for the student." :)

Rather than using an external, non-portable program...

But 'find' is quite portable. Furthermore, the OP mentioned in his title he was using Unix. 'find' has not only been ported to all Unix flavour, it's also found on (almost) any Unix system.

Is it? Please try "find -iname '*foo'" or "find -regextype posix-egrep '[abc]\.html'" on, say, a Solaris system - or one with OS/X. A plain "find" (i.e., no options) would serve the OP's purpose - but it is not portable, and its use in scripts should be discouraged.


--
"Language shapes the way we think, and determines what we can think about."
-- B. L. Whorf

find -name cynlogging.properties -exec perl -p -i.backup -e 's/search/
+replace/g' {} \;
[download]

$ mkdir x

$ cd x

$ mkdir b

$ date > asdf

$ date > b/asdf

$ cat asdf 
Wed Oct  8 13:11:35 MDT 2008

$ find . -name asdf -exec perl -p -i.backup -e 's/1/XXX/g' {} \;

$ cat asdf 
Wed Oct  8 XXX3:XXXXXX:35 MDT 2008

$ cat b/asdf 
Wed Oct  8 XXX3:XXXXXX:37 MDT 2008

$ cat asdf.backup 
Wed Oct  8 13:11:35 MDT 2008
[download]

to run as a perl script do i do system ("find -name cynlogging.properties -exec perl -p -i.backup -e 's/search/ +replace/g' {} \");

I personally believe that if this is a question, then it should be marked with... a question mark. Anyway, the answer is yes, or at least that is a possible way to do it. (Except that, as a minor point, you should quote the backslash.) But more importantly why, precisely, should you run the above line "as a perl script?" The whole point was that probably a single find(1) command is better suited to your need than a whole Perl program. (Although one may consider there that perl is called multiple times in the second case, and this includes a overhead... probably a completely irrelevant consideration, in this particular situation - and there are simple cures, anyway.)

--
If you can't understand the incipit, then please check the IPB Campaign.