in reply to Re: Trying to avoid 9 conditionals
in thread Trying to avoid 9 conditionals

Setting:

my $new_version = '9.4.0';

Prints:

Update aht set major = 9 #DBVersion=9.4.0 Update aht set minor = 4 #DBVersion=9.4.0 Update aht set revision = 0 #DBVersion=9.4.0

which is not quite what the OP seemed to be after.

Update: changed 9.4.6 to 9.4.0 to be consistent with OP's sample.


Perl reduces RSI - it saves typing

Replies are listed 'Best First'.
Re^3: Trying to avoid 9 conditionals
by TGI (Parson) on Oct 16, 2008 at 00:51 UTC

    You are right. I missed the fact that each element in the comment (is it really a comment?) ticks over indvidually.

    The good news is that it's easy enough to modify my code to support that behavior.

    my @current_version = split_version($old_version); my @commands = map { if( $updated[$_]) { # did we update this field? my $current_version = join '.', @current_version; $current_version[$_] = $new_version[$_]; update_aht_command( # if so, generate a command (KEYWORDS)[$_], $new_version[$_], "#DBVersion=$current_version", ) } else { # otherwise put nothing in the command list. (); } } VERSION_ELEMENTS;

    The bad news is that I've now got code with side-effects in my map block. Yuck.

    So in this case I'd probably refactor and use a foreach to iterate my arrays.

    my @current_version = split_version($old_version); my @commands; foreach my $part ( VERSION_ELEMENTS ) { if( $updated[$part]) { # did we update this field? my $current_version = join '.', @current_version; $current_version[$part] = $new_version[$part]; push @commands, update_aht_command( (KEYWORDS)[$part], $new_version[$part], "#DBVersion=$current_version", ) } }

    Warning: I edited this code in the text box on this page and I haven't tested it, it probably has typos, fleas and other bugs.


    TGI says moo