You are right. I missed the fact that each element in the comment (is it really a comment?) ticks over indvidually.
The good news is that it's easy enough to modify my code to support that behavior.
my @current_version = split_version($old_version);
my @commands = map {
if( $updated[$_]) {
# did we update this field?
my $current_version = join '.', @current_version;
$current_version[$_] = $new_version[$_];
update_aht_command( # if so, generate a command
(KEYWORDS)[$_],
$new_version[$_],
"#DBVersion=$current_version",
)
}
else { # otherwise put nothing in the command list.
();
}
} VERSION_ELEMENTS;
The bad news is that I've now got code with side-effects in my map block. Yuck.
So in this case I'd probably refactor and use a foreach to iterate my arrays.
my @current_version = split_version($old_version);
my @commands;
foreach my $part ( VERSION_ELEMENTS ) {
if( $updated[$part]) { # did we update this field?
my $current_version = join '.', @current_version;
$current_version[$part] = $new_version[$part];
push @commands, update_aht_command(
(KEYWORDS)[$part],
$new_version[$part],
"#DBVersion=$current_version",
)
}
}
Warning: I edited this code in the text box on this page and I haven't tested it, it probably has typos, fleas and other bugs.
|